Open
Conversation
ali-behjati
approved these changes
Apr 28, 2022
Collaborator
ali-behjati
left a comment
ali-behjati
left a comment
There was a problem hiding this comment.
The simpler the better! tyvm!
jayantk
reviewed
Apr 28, 2022
Contributor
jayantk
left a comment
jayantk
left a comment
There was a problem hiding this comment.
I think it's fine to leave the low-level API in the readme. It's useful for some people who want to e.g., iterate over the products in Pyth. This documentation has an appropriate warning as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the description of the account structure, which is an implementation detail, and adds a link to the pyth.network docs which explain how to look up the price feed IDs.
Eventually the website will show a definitive list of price feed IDs for each blockchain, but in the meantime this should be documented.