Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type annotations for set_global_params and set_default_params #261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ROCKTAKEY
Copy link

Hello, thanks for maintenance.

I fixed the wrong type annotations on set_global_params and set_default_params.

As we can see Arbitrary argument lists and default argument values, **kwargs: T types kwargs to dict[str, T], not T.

Thus on the code bellow:

def set_default_params(**params: Mapping) -> None:

type of params is dict[str, Mapping], but it should be probably dict[str, Any].

@ROCKTAKEY ROCKTAKEY requested a review from shaypal5 as a code owner March 16, 2025 15:46
@ROCKTAKEY ROCKTAKEY force-pushed the fix-params-type-annotation branch from c32290f to 4c62cee Compare March 16, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant