Fix type annotations for set_global_params
and set_default_params
#261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thanks for maintenance.
I fixed the wrong type annotations on
set_global_params
andset_default_params
.As we can see Arbitrary argument lists and default argument values,
**kwargs: T
typeskwargs
todict[str, T]
, notT
.Thus on the code bellow:
type of
params
isdict[str, Mapping]
, but it should be probablydict[str, Any]
.