feat(silence): allow to silence threads #3122
Conversation
There was a problem hiding this comment.
Thanks for the PR! I haven't tested the code yet, but here are some comments.
A few more things I'd like to point out:
- I'm not sure what you mean by "the annotations were wrong before". Could you elaborate a bit on that?
Threadisn't a subclass ofTextChannelsoTextOrVoiceChannelshould be updated accordingly. Renaming it to something likeSilencableChannelalso seems reasonable.- The existing method names sound pretty inconsistent. This isn't your fault, but maybe they could be updated while we're at it?
Co-authored-by: Daniel Gu <[email protected]>
…t into feat/silence
|
Sorry for the delay, i was busy doing the code jam. I tried to fix the typing issues but a lot of other errors persist from previous code, for example see this, a lot of things are unknown, also the Context annotation always doesn't have the bot type var. I'm using pyright in strict mode so maybe that's why but yeah, there are a lot of typing errors across all the codebase. |
| @@ -242,6 +242,11 @@ async def _set_silence_overwrites(self, channel: TextOrVoiceChannel, *, kick: bo | |||
| send_messages_in_threads=overwrite.send_messages_in_threads | |||
| ) | |||
|
|
|||
| elif isinstance(channel, Thread): | |||
| log.info(f"Silencing thread #{channel.parent}/{channel} ({channel.parent.id}/{channel.id}).") | |||
There was a problem hiding this comment.
My bad, logging this is handled in _silence() instead so this wasn't necessary.
| log.info(f"Silencing thread #{channel.parent}/{channel} ({channel.parent.id}/{channel.id}).") |
| @@ -242,6 +242,11 @@ async def _set_silence_overwrites(self, channel: TextOrVoiceChannel, *, kick: bo | |||
| send_messages_in_threads=overwrite.send_messages_in_threads | |||
| ) | |||
|
|
|||
| elif isinstance(channel, Thread): | |||
| log.info(f"Silencing thread #{channel.parent}/{channel} ({channel.parent.id}/{channel.id}).") | |||
| await channel.edit(locked=True) | |||
There was a problem hiding this comment.
If the thread is already locked, this will just schedule an unlock in the set amount of time. Failing is probably better to keep consistent with how it behaves with text channels.
| @@ -331,6 +340,12 @@ async def _unsilence(self, channel: TextOrVoiceChannel) -> bool: | |||
| role = self._everyone_role | |||
| overwrite = channel.overwrites_for(role) | |||
| permissions = "`Send Messages` and `Add Reactions`" | |||
| elif isinstance(channel, Thread): | |||
| await channel.edit(locked=False) | |||
There was a problem hiding this comment.
Same as above: if the thread was manually unlocked before the scheduled time, there won't be any indication of it.
vivekashok1221
added
the
s: waiting for author
The code might not be that clean, also i think that the annotations were wrong before, now they are surely wrong, do you care about them?
Also, since this is my first contribution to this repository, let me know if i missed anything out.