Skip to content

Add official support for Python 3.14 #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −5
Open

Add official support for Python 3.14 #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aac7bdd
Add official support for Python 3.14
edgarrmondragon Nov 6, 2025
ff0ab3c
Merge branch 'main' into py314
edgarrmondragon Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
strategy:
matrix:
os: [ubuntu, windows, macos]
py: ['3.9', '3.10', '3.11', '3.12', '3.13']
py: ['3.9', '3.10', '3.11', '3.12', '3.13', '3.14']
name: "Test on ${{ matrix.os }}, py${{ matrix.py }}"
runs-on: "${{ matrix.os }}-latest"
steps:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ CHANGELOG
Unreleased
----------

- Add official support for Python 3.14
- Add Citation File Format schema and pre-commit hook. Thanks :user:`edgarrmondragon`! (:issue:`502`)

.. vendor-insert-here
Expand Down
4 changes: 4 additions & 0 deletions tests/unit/test_cachedownloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,10 @@ def dummy_validate_bytes(data):
assert validator_ran is False


@pytest.mark.skipif(
platform.system() == "Windows",
reason="time.tzset() is not available on Windows",
)
Copy link
Member

@sirosen sirosen Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 I should probably go back over the test to figure out a compatible way of setting the timezone. But this will do for now.

Copy link
Contributor Author

@edgarrmondragon edgarrmondragon Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, FWIW I noticed this on main (e.g. https://github.com/python-jsonschema/check-jsonschema/actions/runs/19238976727/job/54996498981) and thought it was a good idea to handle it in this PR.

I don't know of any good alternatives for monkeypatching the timezone, unfortunately 😕.

def test_lastmod_from_header_uses_gmtime(request, monkeypatch, default_response):
"""
Regression test for https://github.com/python-jsonschema/check-jsonschema/pull/565
Expand Down
8 changes: 4 additions & 4 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ envlist =
mypy
cov_clean
py39-mindeps{,-format}
py{313,312,311,310,39}
py{39,313}-{json5,pyjson5}{,-format}
py{39,313}-{disable_orjson}
py{314,313,312,311,310,39}
py{39,314}-{json5,pyjson5}{,-format}
py{39,314}-{disable_orjson}
cov_combine
cov_report
skip_missing_interpreters = true
Expand Down Expand Up @@ -45,7 +45,7 @@ description = "combine coverage data"
deps = coverage
skip_install = true
commands = coverage combine
depends = py{,38,39,310,311,312,313}{,-mindeps,-format,-json5,-pyjson5,-disable_orjson}
depends = py{,39,310,311,312,313,314}{,-mindeps,-format,-json5,-pyjson5,-disable_orjson}

[testenv:cov_report]
description = "report test coverage"
Expand Down
Loading