Skip to content

trio_websocket/_impl.py: Don't reply to pings on a locally closed connection #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion trio_websocket/_impl.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you-- would you mind trying to add unit test coverage for this?

Original file line number Diff line number Diff line change
Expand Up @@ -1495,7 +1495,8 @@ async def _handle_ping_event(self, event: wsproto.events.Ping) -> None:
:param wsproto.events.Ping event:
'''
logger.debug('%s ping %r', self, event.payload)
await self._send(event.response())
if self._wsproto.state != ConnectionState.LOCAL_CLOSING:
await self._send(event.response())

async def _handle_pong_event(self, event: wsproto.events.Pong) -> None:
'''
Expand Down