Issue 1359 #2159
Merged
Issue 1359 #2159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a structural change. I added a Class object with a include method. This follows leaflet's `L.Class.include` statement. This allows users to override Leaflet class behavior. The motivating example for this can be found in the added `test_include` in `test_map.py`. Using an include, users can override the `createTile` method of `L.TileLayer` and add a headers.
Add an include statement, that will allow users to override specific methods at Leaflet level. This allows users to customize the "createTile" method using a JsCode object.
ocefpaf
reviewed
Jun 16, 2025
|
This PR needed docs, linting/formatting fixes, and I'm not sure why Streamlit tests are not passing. |
Noted. The Streamlit tests I solved while fixing another issue and will be gone after a rebase. |
ocefpaf
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Class.include statement.
This allows users to override methods on the Leaflet level.
This can be used to override the
createTilemethod inLeafletby adding a Bearer Token to the request. A motivating example can be found in the tests.