Skip to content

Update README to point to the extra plugin #2161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 13, 2025
Merged

Update README to point to the extra plugin #2161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
22aa1e5
Update README to point to the extra plugin
hansthen Jun 11, 2025
79f548f
Try fixing failing CI
hansthen Jun 11, 2025
5e7da4b
More trial and error
hansthen Jun 11, 2025
b8af05f
Updated after review comment
hansthen Jun 12, 2025
5904750
Update after review comments
hansthen Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions .github/workflows/test_streamlit_folium.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,14 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: '3.x'

- name: Checkout Folium
uses: actions/checkout@v4

- name: Setup Micromamba env
uses: mamba-org/setup-micromamba@v2
with:
environment-name: TEST
create-args: >-
python=3
--file requirements.txt

- name: Checkout Streamlit Folium
uses: actions/checkout@v4
with:
Expand All @@ -41,7 +38,9 @@ jobs:
- name: Install streamlit_folium dev dependencies
shell: bash -l {0}
run: |
conda install --file streamlit_folium/tests/requirements.txt
cd streamlit_folium
python -m pip install --upgrade pip
pip install -r tests/requirements.txt
Comment on lines -44 to +43
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make this a Python only project instead of mixing with micromamba here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes makes sense. Streamlit-folium is also pip only.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are not using the python GitHub Action there, right? I'm afraid that, using whatever Pyhton is available in the image may bring unexpected results/problems later on.


- name: Install streamlit-folium
shell: bash -l {0}
Expand All @@ -60,7 +59,7 @@ jobs:
- name: Install folium from source
shell: bash -l {0}
run: |
python -m pip install -e . --no-deps --force-reinstall
python -m pip install -e . --force-reinstall

- name: Test with pytest and retry flaky tests up to 3 times
shell: bash -l {0}
Expand Down
1 change: 1 addition & 0 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,3 +82,4 @@ Plugins:
- https://github.com/onaci/folium-glify-layer: provide fast webgl rendering for large GeoJSON FeatureCollections
- https://github.com/carlosign/Folium.ControlCredits-Plugin: displaying credits in the corner. Display an image/logo, clicking it will expand to show a brief message with credits and links.
- https://github.com/JohnyCarrot/folium-geocoder-own-locations: a geocoder that accepts a list of suggestions at creation time.
- https://github.com/iwpnd/folium-vectortilelayer: a tile layer that zooms and stretches beyond the maximum and minimum of the tile provider
Loading