Add check-requirements-resolve command #593
Conversation
This command checks that the top-level entries in the provided requirements.txt and/or constraints.txt files resolve. Usage: fromager check-requirements-resolve "path/to/constraints.txt" "path/to/requirements.txt" Signed-off-by: Daniel Thau <[email protected]>
| except InvalidRequirement as err: | ||
| logger.error(f"{path}: invalid requirement {line!r}: {err}") | ||
| failure = True | ||
| continue |
There was a problem hiding this comment.
The bootstrap command has some code to get the requirements, including filtering out requirements that are not relevant based on the current environment markers. How likely is it that we would need to do similar filtering in the linter?
There was a problem hiding this comment.
Our main aim with the lint command is to do an early and inexpensive check of what will be repeated behavior in the bootstrap command. Given that, so long as it's inexpensive, it's probably best to keep the behavior identical in this regard. I'll adjust it accordingly.
|
We talked about this offline, and I think you said you were going to merge the feature into the existing linter. Am I remembering that correctly, or should we merge this PR? |
This command checks that the top-level entries in the provided requirements.txt and/or constraints.txt files resolve.
Usage:
fromager check-requirements-resolve "path/to/constraints.txt" "path/to/requirements.txt"