fix use of log context in bootstrapper #595
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhellmann
force-pushed
the
fix-log-record-context
branch
from
66dfcad to
30e7c7a
Compare
tiran
reviewed
May 4, 2025
| @@ -360,11 +367,9 @@ def _handle_build_requirements( | |||
| self.progressbar.update_total(len(build_dependencies)) | |||
|
|
|||
| for dep in self._sort_requirements(build_dependencies): | |||
| token = requirement_ctxvar.set(dep) | |||
There was a problem hiding this comment.
With this change build_environment.maybe_install() has no longer the correct context var. #598 should fix the bug.
There was a problem hiding this comment.
I'll have to have a look at that. The bootstrap() function should be the top level function, so handling the context there should cover everything.
The original implementation managed the context only for some types of dependencies. This change moves the handling into the bootstrap() method where it can be applied to all dependencies. Signed-off-by: Doug Hellmann <[email protected]>
dhellmann
force-pushed
the
fix-log-record-context
branch
from
30e7c7a to
ceb66dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation managed the context only for some types of dependencies. This change moves the handling into the bootstrap() method where it can be applied to all dependencies.