-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-126413: Add translation tests for getopt
and optparse
#126698
Conversation
Not entirely sure if this needs a news entry, adding |
I think we can skip NEWS for test improvements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
Thanks @tomasr8 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, @tomasr8 and @serhiy-storchaka, I could not cleanly backport this to
|
Sorry, @tomasr8 and @serhiy-storchaka, I could not cleanly backport this to
|
Thanks for the review! I'll deal with the backports tomorrow :) |
…pythonGH-126698) (cherry picked from commit dff074d) Co-authored-by: Tomas R. <[email protected]>
GH-126755 is a backport of this pull request to the 3.13 branch. |
GH-126756 is a backport of this pull request to the 3.12 branch. |
This is a followup from #124295
Given that the tests for
getopt
andoptparse
are essentially the same as the ones forargparse
, I extracted the snapshot file generation and comparison intotest.support.i18n_helper
in order not to repeat the code three times. The majority of the diff is just moving that code fromtest_argpase
totest.support.i18n_helper
.Just like for
argparse
, the snapshots are generated inLib/test/translationdata
and are updated the same way using--snapshot-update
.