Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-126433: Update hacl-star #126791

Merged
merged 2 commits into from
Nov 15, 2024
Merged

gh-126433: Update hacl-star #126791

merged 2 commits into from
Nov 15, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 13, 2024

Run Modules/_hacl/refresh.sh and update SBOM.

Retrieve the change: "Lib_Memzero0.c: Fix compiler warning on 32-bit Windows".

@vstinner
Copy link
Member Author

cc @msprotz

Run Modules/_hacl/refresh.sh and update SBOM.

Retrieve the change: "Lib_Memzero0.c: Fix compiler warning on 32-bit
Windows".
@vstinner vstinner changed the title gh-126448: Update hacl-star gh-126433: Update hacl-star Nov 13, 2024
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from an SBOM POV, thanks!

@vstinner
Copy link
Member Author

@sobolevn: This change should fix the last compiler warning on 32-bit Windows:

D:\a\cpython\cpython\Modules_hacl\Lib_Memzero0.c(39,27): warning C4244: 'function': conversion from 'uint64_t' to 'SIZE_T', possible loss of data [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't ever touched hacl, but the warning is gone 🎉

@gpshead
Copy link
Member

gpshead commented Nov 13, 2024

@msprotz
Copy link
Contributor

msprotz commented Nov 13, 2024

👍

@vstinner
Copy link
Member Author

vstinner commented Nov 14, 2024

https://github.com/python/cpython/actions/runs/11822087838/job/32938420386?pr=126791 to update the SBOM please

I don't understand why make regen-sbom didn't update Misc/sbom.spdx.json locally. But ok, I applied the linked change.

@gpshead gpshead enabled auto-merge (squash) November 15, 2024 00:09
@gpshead gpshead added the needs backport to 3.13 bugs and security fixes label Nov 15, 2024
@picnixz
Copy link
Contributor

picnixz commented Nov 15, 2024

@gpshead This likely also needs a 3.12 backport right?

@gpshead gpshead merged commit 3fecbe9 into python:main Nov 15, 2024
41 checks passed
@miss-islington-app
Copy link

Thanks @vstinner for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @vstinner and @gpshead, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3fecbe9255391be1ac3c3b52dfe0254ee5c665bd 3.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants