-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-128307: support eager_start kwarg in create_eager_task_factory, and pass kwargs from asyncio.create_task and TaskGroup.create_task #128306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gvanrossum
merged 26 commits into
python:main
from
graingert:add-eager-start-to-create-task
May 5, 2025
Merged
Changes from 6 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
23d2c42
support eager_start kwarg in create_eager_task_factory
graingert da5cab3
📜🤖 Added by blurb_it.
blurb-it[bot] 7bce401
Update Misc/NEWS.d/next/Library/2024-12-28-11-01-36.gh-issue-128307.B…
graingert 8ad26fc
Update Lib/asyncio/base_events.py
graingert 90f9ef2
Update Lib/asyncio/tasks.py
graingert 1107608
use presense rather than None-ness to determine default eager_start b…
graingert ec3bd14
Update Doc/library/asyncio-eventloop.rst
graingert 939c3f5
Merge branch 'main' into add-eager-start-to-create-task
graingert d24d43b
Update Misc/NEWS.d/next/Library/2024-12-28-11-01-36.gh-issue-128307.B…
graingert d8369c3
Merge branch 'main' into add-eager-start-to-create-task
graingert 4a4ad1b
Apply suggestions from code review
graingert 813398c
Merge branch 'main' into add-eager-start-to-create-task
graingert dfafc7a
Merge branch 'main' into add-eager-start-to-create-task
graingert 3175aae
use self.current_task
graingert 0598877
Merge branch 'main' into add-eager-start-to-create-task
graingert 3e8e2a8
Merge branch 'main' into add-eager-start-to-create-task
graingert 1c10063
Merge branch 'main' into add-eager-start-to-create-task
graingert 5288bf2
Merge branch 'main' into add-eager-start-to-create-task
graingert 14e0536
Update Doc/library/asyncio-eventloop.rst
graingert 73a20a5
Merge branch 'main' into add-eager-start-to-create-task
graingert c92e2fa
test eager start with default factory
graingert 8aab5f1
Merge branch 'main' into add-eager-start-to-create-task
graingert a410125
Merge branch 'main' into add-eager-start-to-create-task
graingert 1a45d43
Change TaskGroup.create_task and tasks.create_task to **kwargs
gvanrossum-ms 7654a85
Fix bug I introduced in tasks.create_task()
gvanrossum-ms 74b02d4
Update Lib/asyncio/tasks.py
graingert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Library/2024-12-28-11-01-36.gh-issue-128307.BRCYTA.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Add ``eager_start`` keyword argument to :func:`loop.create_task` | ||
graingert marked this conversation as resolved.
Show resolved
Hide resolved
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.