Remove unused import

[Marius-Juston]

I noticed that test_selector_events.py and asyncio/selector_event.py both have

try:
    import ssl
except ImportError:
    ssl = None

where the ssl module is never used, should these be removed? Removing the one in test_selector_event.py causes no problems in the tests; however removing the one in asyncio/selector_event.py causes a single error:

test test.test_asyncio.test_selector_events failed -- Traceback (most recent call last):
  File "/home/marius/cpython/Lib/unittest/mock.py", line 1424, in patched
    with self.decoration_helper(patched,
         ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
                                args,
                                ^^^^^
                                keywargs) as (newargs, newkeywargs):
                                ^^^^^^^^^
  File "/home/marius/cpython/Lib/contextlib.py", line 141, in __enter__
    return next(self.gen)
  File "/home/marius/cpython/Lib/unittest/mock.py", line 1406, in decoration_helper
    arg = exit_stack.enter_context(patching)
  File "/home/marius/cpython/Lib/contextlib.py", line 530, in enter_context
    result = _enter(cm)
  File "/home/marius/cpython/Lib/unittest/mock.py", line 1498, in __enter__
    original, local = self.get_original()
                      ~~~~~~~~~~~~~~~~~^^
  File "/home/marius/cpython/Lib/unittest/mock.py", line 1468, in get_original
    raise AttributeError(
        "%s does not have the attribute %r" % (target, name)
    )
AttributeError: <module 'asyncio.selector_events' from '/home/marius/cpython/Lib/asyncio/selector_events.py'> does not have the attribute 'ssl'

While looking through I also saw in mailbox.py there is the

class Mailbox:
    """A group of messages in a particular place."""

    def __init__(self, path, factory=None, create=True):
        """Initialize a Mailbox instance."""
        self._path = os.path.abspath(os.path.expanduser(path))
        self._factory = factory

where the variable create is never used, this could most likely be removed?

[ZeroIntensity]

where the variable create is never used, this could most likely be removed?

No, that would be a breaking change.

[AA-Turner]

'Style' PRs aren't accepted, and if the rationale for removing the imports is performance, we would need benchmarks for each module demonstrating an improvement.

A

[terryjreedy]

Actually, PRs that remove unused imports, often as detected by linters, are not unknown and have been done by core devs to 'clean up' a module. This is assuming that the presence of the name is not a documented part of the module interface.

[Marius-Juston]

Yeah, I just looking through the library modules and saw through the linter that some modules had been deemed as "unused" so I thought that they might have been mistakenly forgotten (potentially due to other changes in function implementations). Just wanted to bring these up in case that was indeed the case!