Skip to content

gh-109981: Resolve situation on iOS regarding fd_count. #132823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 23, 2025

Conversation

johnzhou721
Copy link
Contributor

macOS Sonoma seems to have issues with support.fd_count, at gh-109981. However, after experimenting using macOS Sonoma on an attempt to support visionOS unofficially through another project, the simulator is hard-crashing, leading to the conclusion that this probably applies on all Apple platforms. Hence this patch.

@freakboy3742 (since he supports stuff for iOS)

macOS Sonoma seems to have issues with support.fd_count, at
pythongh-109981. However, after experimenting using macOS Sonoma
on an attempt to support visionOS unofficially through another
project, the simulator is hard-crashing, leading to the con-
clusion that this probably applies on all Apple platforms.
Hence this patch.
@python-cla-bot
Copy link

python-cla-bot bot commented Apr 23, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Apr 23, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Apr 23, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@freakboy3742
Copy link
Contributor

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 2ba9225 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132823%2Fmerge

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

@freakboy3742 freakboy3742 self-assigned this Apr 23, 2025
@freakboy3742 freakboy3742 added OS-ios needs backport to 3.13 bugs and security fixes labels Apr 23, 2025
@johnzhou721
Copy link
Contributor Author

And... done.
Windows free-threading is so slow\dots{}

Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small tweak to the release note; but otherwise, looks good - thanks for the patch!

@freakboy3742 freakboy3742 enabled auto-merge (squash) April 23, 2025 02:59
@freakboy3742 freakboy3742 merged commit 862fd89 into python:main Apr 23, 2025
39 checks passed
@miss-islington-app
Copy link

Thanks @johnzhou721 for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 23, 2025
…GH-132823)

Modifies the test helper that counts the list of open file descriptors to use
the optimised ``/dev/fd`` approach on all Apple platforms, not just macOS. This
avoids crashes caused by guarded file descriptors.
(cherry picked from commit 862fd89)

Co-authored-by: John <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Apr 23, 2025

GH-132824 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 23, 2025
freakboy3742 pushed a commit that referenced this pull request Apr 23, 2025
…2823) (#132824)

Modifies the test helper that counts the list of open file descriptors to use
the optimised ``/dev/fd`` approach on all Apple platforms, not just macOS. This
avoids crashes caused by guarded file descriptors.
(cherry picked from commit 862fd89)

Co-authored-by: John <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants