-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
gh-109981: Resolve situation on iOS regarding fd_count. #132823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
macOS Sonoma seems to have issues with support.fd_count, at pythongh-109981. However, after experimenting using macOS Sonoma on an attempt to support visionOS unofficially through another project, the simulator is hard-crashing, leading to the con- clusion that this probably applies on all Apple platforms. Hence this patch.
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
!buildbot iOS |
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 2ba9225 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132823%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
And... done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small tweak to the release note; but otherwise, looks good - thanks for the patch!
Misc/NEWS.d/next/Tests/2025-04-23-02-23-37.gh-issue-109981.IX3k8p.rst
Outdated
Show resolved
Hide resolved
Thanks @johnzhou721 for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…GH-132823) Modifies the test helper that counts the list of open file descriptors to use the optimised ``/dev/fd`` approach on all Apple platforms, not just macOS. This avoids crashes caused by guarded file descriptors. (cherry picked from commit 862fd89) Co-authored-by: John <[email protected]>
GH-132824 is a backport of this pull request to the 3.13 branch. |
…2823) (#132824) Modifies the test helper that counts the list of open file descriptors to use the optimised ``/dev/fd`` approach on all Apple platforms, not just macOS. This avoids crashes caused by guarded file descriptors. (cherry picked from commit 862fd89) Co-authored-by: John <[email protected]>
macOS Sonoma seems to have issues with support.fd_count, at gh-109981. However, after experimenting using macOS Sonoma on an attempt to support visionOS unofficially through another project, the simulator is hard-crashing, leading to the conclusion that this probably applies on all Apple platforms. Hence this patch.
@freakboy3742 (since he supports stuff for iOS)