- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 33.3k
 
          gh-139871: Add bytearray.take_bytes([n]) to efficiently extract bytes
          #140128
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            cmaloney
  wants to merge
  39
  commits into
  python:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
cmaloney:bytearray_bytes
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
      
        
          +397
        
        
          −94
        
        
          
        
      
    
  
  
     Open
                    Changes from 23 commits
      Commits
    
    
            Show all changes
          
          
            39 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      daf8e02
              
                gh-139871: Update bytearray to contain PyBytesObject
              
              
                cmaloney 39b2d15
              
                📜🤖 Added by blurb_it.
              
              
                blurb-it[bot] 86faf1d
              
                Add bytearray.take_bytes
              
              
                cmaloney a9328f4
              
                Merge branch 'main' into bytearray_bytes
              
              
                cmaloney e9f5ca9
              
                Update Objects/bytearrayobject.c
              
              
                cmaloney 4784957
              
                Review fixes
              
              
                cmaloney db19def
              
                Merge branch 'main' into bytearray_bytes
              
              
                cmaloney 451c302
              
                Update Objects/bytearrayobject.c
              
              
                cmaloney bab7151
              
                Add tests around alloc and getsizeof that show clearing isn't working…
              
              
                cmaloney cb2377c
              
                Fix resizing to 0 length / clearing leaving one byte alloc
              
              
                cmaloney 20175f8
              
                review fix: handle NULL return from from PyBytes_FromStringAndSize
              
              
                cmaloney e485595
              
                Add take_bytes to test_free_threading
              
              
                cmaloney b5535d0
              
                Missed line...
              
              
                cmaloney 7c6e8a8
              
                Simplify getting out ob_bytes
              
              
                cmaloney 4e27d13
              
                Include PyBytesObject in __alloc__ of bytearray.
              
              
                cmaloney 9887dad
              
                Apply suggestion from @vstinner
              
              
                cmaloney 6e4b910
              
                Don't multiply by sizeof(char) as it's always 1
              
              
                cmaloney b6f8403
              
                Rely on bytes for end of buffer NULL
              
              
                cmaloney 28cb8c5
              
                Personal review fixes
              
              
                cmaloney f03b895
              
                Simplify resize error handling
              
              
                cmaloney a45f3c2
              
                Use right PyLong constructor
              
              
                cmaloney c8943e3
              
                Add a define for max bytearray size, comment size=0
              
              
                cmaloney 5bffb7e
              
                Remove oold comment
              
              
                cmaloney 583ea4b
              
                Update test_capi.test_bytearray for MemoryError vs OverflowError
              
              
                cmaloney 8ee14e6
              
                More accurate size and alloc calculation
              
              
                cmaloney d70e369
              
                Comment and minor doc tweaks
              
              
                cmaloney 97be818
              
                Apply suggestion from @vstinner
              
              
                cmaloney 99e49ef
              
                Remove _PyByteArray_empty_string, add bytearray_reinit_from_bytes
              
              
                cmaloney f4b62d9
              
                Update Stable API concerns: restore _empty_string an dmove _PyBytesOb…
              
              
                cmaloney 48afb62
              
                Restore _PyByteArray_empty_string in .c file
              
              
                cmaloney 8c81e03
              
                remove line that shouldn't have been added
              
              
                cmaloney 313e78c
              
                Apply suggestion from @encukou
              
              
                cmaloney c028e2b
              
                Remove original variable, no longer used
              
              
                cmaloney a69b338
              
                remove _PyByteArray_empty_string
              
              
                cmaloney 2a95118
              
                Add take_bytes_n free-threading test
              
              
                cmaloney 9680e8a
              
                Expand comment for ob_alloc
              
              
                cmaloney 02882af
              
                Add note on memmove tradeoff
              
              
                cmaloney b67d10c
              
                Move suggested optimizing refactors to whatsnew
              
              
                cmaloney 6db8822
              
                Remove unintended change
              
              
                cmaloney File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
        
          
          
            2 changes: 2 additions & 0 deletions
          
          2 
        
  Misc/NEWS.d/next/Core_and_Builtins/2025-10-14-18-24-16.gh-issue-139871.SWtuUz.rst
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Update :class:`bytearray` to use a :class:`bytes` under the hood as its buffer | ||
| and add :func:`bytearray.take_bytes` to take it out. | 
      
      Oops, something went wrong.
        
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to put porting notes better in What's New, rather than in general documentation? In a few years,
take_byteswon't be “new”.The
versionaddednote could link to the 3.15 What's New.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
End state to me is these (hopefully) get incorporated into
flake8/ruffas code improvement suggestions rather than more things to memorize. To that end maybe justbytes(bytearray())->.take_bytes()in what's new would be enough and rely on external pieces to socialize more (ex. I'm planning to try and teach this a bit through blogs/talks if it ships).I slightly prefer on
bytearrayso someone hand-optimizingbytearraycode and browsing the page for alternatives will find them. The less efficient patterns are stable Python APIs to me so it's similar to https://docs.python.org/3/library/pathlib.html#corresponding-tools and applies both in3.15specifically and forseeable future versions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the table can be improved here, but as it is it looks out of place to me.
Exactly -- and the more ephemeral-looking What's New seems better for that.
That's why I suggested the link to What's New :)
IMO, that's a very different thing: those docs say “pathlib is not a drop-in replacement for os.path”. It's a two-way mapping, not “old→new” porting suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Still looking at / experimenting with this one, changes for others comments pushed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to whatsnew; not fully satisfied with my wording but also assuming will rework over time (ex. reference
stdlibimprovements as they get added)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One benefit of What's New is that there'll be a reorganization pass closer to the release :)