Skip to content

gh-141141: Make base64.b85decode thread safe #141149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2025
Merged

gh-141141: Make base64.b85decode thread safe #141149

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c413e0
Make base64.b85decode thread safe - issue 141141
benel-tayar-bd Nov 6, 2025
4796813
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 6, 2025
c4d8f4e
rename b85dec_tmp
beneltayar Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Lib/base64.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,9 +462,12 @@ def b85decode(b):
# Delay the initialization of tables to not waste memory
# if the function is never called
if _b85dec is None:
_b85dec = [None] * 256
# we don't assign to _b85dec directly to avoid issues when
# multiple threads call this function simultaneously
_b85dec_tmp = [None] * 256
for i, c in enumerate(_b85alphabet):
_b85dec[c] = i
_b85dec_tmp[c] = i
_b85dec = _b85dec_tmp

b = _bytes_from_decode_data(b)
padding = (-len(b)) % 5
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2025-11-06-15-11-50.gh-issue-141141.tgIfgH.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a thread safety issue with :func:`base64.b85decode`. Contributed by Benel Tayar.
Loading