-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
gh-140500: Update download.html instructions #141320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Missing "the" in the description Closes python#140500
This comment was marked as resolved.
This comment was marked as resolved.
|
Please also do #140523 (comment) |
|
@StanFromIreland I'm confused, https://github.com/python/cpython/pull/140523/files seems like it's identical to this, but it wasn't merged. Are you saying to make the changes mentioned: -To download an archive containing all the documents for this version of Python in one of various formats, follow one of the links in this table.
+Download an archive containing all the documentation for this version of Python:-These archives contain all the content in the documentation.
+ |
|
Yes, please do what Hugo asked in the linked comment. |
Updated download page text for clarity and conciseness requested by @hugovk
Co-authored-by: Joseph Anthony Pasquale Holsten <[email protected]>
Co-authored-by: Joseph Anthony Pasquale Holsten <[email protected]>
StanFromIreland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please do not use the Update Branch button unless necessary (e.g. fixing conflicts, jogging the CI, or very old PRs) as it uses valuable resources. For more information see the devguide.
hugovk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks all!
|
Thanks @KarinaS0uza for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @KarinaS0uza for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
(cherry picked from commit 6d710a7) Co-authored-by: Karina Souza <[email protected]> Co-authored-by: Joseph Anthony Pasquale Holsten <[email protected]>
|
GH-141346 is a backport of this pull request to the 3.13 branch. |
(cherry picked from commit 6d710a7) Co-authored-by: Karina Souza <[email protected]> Co-authored-by: Joseph Anthony Pasquale Holsten <[email protected]>
|
GH-141347 is a backport of this pull request to the 3.14 branch. |
) Co-authored-by: Karina Souza <[email protected]> Co-authored-by: Joseph Anthony Pasquale Holsten <[email protected]>
) Co-authored-by: Karina Souza <[email protected]> Co-authored-by: Joseph Anthony Pasquale Holsten <[email protected]>
Missing "the" in the description
Closes #140500
📚 Documentation preview 📚: https://cpython-previews--141320.org.readthedocs.build/