Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recomend podman instead of docker and remove mentions to Docker images #1442

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

picnixz
Copy link
Contributor

@picnixz picnixz commented Oct 13, 2024

Fixes #1441.

This also simplifies the instructions, removing the systemd part (because honestly, I think it could be more confusing than helping if someone is not using systemd or does not know how to use it...). Using podman is much simpler and if there's any issue we can help them directly in their PR.


📚 Documentation preview 📚: https://cpython-devguide--1442.org.readthedocs.build/

@picnixz
Copy link
Contributor Author

picnixz commented Oct 13, 2024

Concerning the creation of files owned by the root user by the docker service, this is something I encountered but not always. AFAIK, podman does not any super-user permissions and would not create files owned by root (I honestly don't know what happened).

Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR you can commit review suggestions directly from GitHub, either individually or in a single batch from the "files changed" tab.

@picnixz
Copy link
Contributor Author

picnixz commented Oct 14, 2024

FTR you can commit review suggestions directly from GitHub, either individually or in a single batch from the "files changed" tab.

Yes I know, but I didn't commit your suggestion because I wanted to split the line somewhere else (just to make it more or less aligned with the rest of the paragraph). I also avoid to use the GH UI if I'm on my dev env since otherwise I need to remember to pull from my remote branch :')

@ezio-melotti ezio-melotti merged commit 5028ad3 into python:main Oct 14, 2024
4 checks passed
@picnixz picnixz deleted the update-devguide-docker-images branch October 14, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace container images to packages from cpython-devcontainers
3 participants