Cleanup generic class variable access #19292
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: ibis (https://github.com/ibis-project/ibis)
- ibis/common/bases.py:110: error: Unsupported target for indexed assignment ("Mapping[Any, Any]") [index]
+ ibis/common/bases.py:110: error: Unsupported target for indexed assignment ("Mapping[Any, Self]") [index]
hydpy (https://github.com/hydpy-dev/hydpy)
+ hydpy/core/variabletools.py:2448: error: Unused "type: ignore" comment [unused-ignore]
artigraph (https://github.com/artigraph/artigraph)
- src/arti/internal/mappings.py:100: error: ClassVar cannot contain type variables [misc]
+ src/arti/storage/__init__.py:74: error: Unused "type: ignore" comment [unused-ignore]
comtypes (https://github.com/enthought/comtypes)
+ comtypes/hints.pyi:56: error: Unused "type: ignore" comment [unused-ignore]
pwndbg (https://github.com/pwndbg/pwndbg)
- pwndbg/aglib/heap/structs.py:175: error: Access to generic instance variables via class is ambiguous [misc]
- pwndbg/aglib/heap/structs.py:206: error: Access to generic instance variables via class is ambiguous [misc]
|
|
|
JukkaL
reviewed
Jun 16, 2025
| x: Tuple[Unpack[Ts]] | ||
|
|
||
| reveal_type(C.x) # E: Access to generic instance variables via class is ambiguous \ | ||
| # N: Revealed type is "builtins.tuple[Any, ...]" |
There was a problem hiding this comment.
Test also defining a subclass and then accessing the attribute via the subclass, and an instance of the subclass?
| [case testSelfTypeClassMethodNotSilentlyErased] | ||
| from typing import ClassVar, Self, Optional | ||
|
|
||
| class X: |
There was a problem hiding this comment.
Test subclassing and accessing _inst outside the class body?
| x: T | ||
| y: ClassVar[T] | ||
|
|
||
| class C(B[T]): ... |
There was a problem hiding this comment.
I think it would be good to also test attribute access in cases like class D(B[int]): .... Should D.y have type int then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5144
Fixes #15223
This is related to the work on #7724
Now that all attribute access goes through
checkmember.pythere is not much benefit in giving an error at the definition site, especially that it prohibits some valid (and common) use cases, see comments in #5144. While looking at this I discovered a bunch of defects in the implementation, that I also fix (I am keeping unsafe self-type related logic as is):Anyeven in allowed use casesTypeVarTupleandParamSpecwere not handled as equal to regular type variables (I guess because of old problems with erasing them)