Skip to content

fix: optimize overloaded signatures check #20378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi merged 1 commit into from
Dec 8, 2025
Merged

fix: optimize overloaded signatures check #20378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mypy/checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8751,8 +8751,9 @@ def is_unsafe_overlapping_overload_signatures(
# Note: We repeat this check twice in both directions compensate for slight
# asymmetries in 'is_callable_compatible'.

other_expanded = expand_callable_variants(other)
for sig_variant in expand_callable_variants(signature):
for other_variant in expand_callable_variants(other):
for other_variant in other_expanded:
# Using only expanded callables may cause false negatives, we can add
# more variants (e.g. using inference between callables) in the future.
if is_subset_no_promote(sig_variant.ret_type, other_variant.ret_type):
Expand Down