[mypyc] Fix compilation of byteswriter_extra_ops #20403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Dec 12, 2025
| skipitem(const char **p_format, va_list *p_va) | ||
| { | ||
| const char *format = *p_format; | ||
| char c = *format++; |
Collaborator
There was a problem hiding this comment.
This changes behavior -- switch to format++;?
JukkaL
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling byteswriter_extra_ops.c on its own fails because it uses types from Python.h without including it so add the include directive.
It also references
BytesWriterObjectwhich is defined only whenMYPYC_EXPERIMENTALis defined so wrap the functions with the sameifdef.Also add the explicit include of Python.h in other header files that currently rely on the file being included above them when compiling. Remove unused variables.