Fix package build failure when the compiler types not defined (Fixes #20428) #20429
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I will sync this to librt (and make a new release) tomorrow, unless @hauntsaninja you want to try doing the |
Collaborator
|
Would be open to trying over the weekend! |
Member
|
@hauntsaninja Great! I just sent you an invite to mypyc org. Please follow instructions in README in https://github.com/mypyc/librt. If you are not sure about anything, please ask either here or on Discord, I will be around for most of the weekend. |
Member
|
@hauntsaninja Are you still interested in doing this? |
Collaborator
|
Yes! I only got the GitHub invite, not the PyPi invite — meant to ask you about it |
Member
|
You don't need any PyPI permissions for this, PyPI publishing is done using trusted publishing. |
Collaborator
|
Okay great! 0.7.5 is released with this change. Was very straightforward :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the install issue #20428 by adding a default value when a compiler type is not defined. While this fix is specifically for z/OS, it should also fix other platforms that have their compiler_type changed in distutils/setuptools such as mingw32.
I tested this with installing the librt package. I've added no testcases as there's no new functionality.