Skip to content

@override in _type_checker_internals.TypedDictFallback #14115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jorenham
Copy link
Contributor

@jorenham jorenham commented May 21, 2025

Due to a bug in the pyright github action, the _typeshed._type_checker_internals module is being checked by pyright in the CI of scipy-stubs. And apparently, was @override one some methods in TypedDictFallback, causing the CI to fail (see e.g. https://github.com/scipy/scipy-stubs/actions/runs/15169287965/job/42655058438?pr=521). And just to be clear, I don't consider this to be the fault of typeshed or anything. I just figured that I might as well add those @override's, for the sake of completeness I suppose 🤷.

@AlexWaygood
Copy link
Member

Hmm, we don't generally decorate methods with @override in typeshed, and there's some debate about whether it would really be useful for us given our existing CI tooling (see #10871)

@jorenham
Copy link
Contributor Author

Hmm, we don't generally decorate methods with @override in typeshed, and there's some debate about whether it would really be useful for us given our existing CI tooling (see #10871)

Yea I expected something like that, I just thought I'd give it a shot either way. Thanks for the review :)

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants