Move float conversion functions from Types.h into new FloatConversion.h #3760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Summary: There is a lot of inline code in `Types.h` for converting between different floating point types and I am about to add even more. However most users of this header are only interested in the `float16`, etc. type definitions but don't use the conversions. It seems like a good idea to move the conversion code to a separate `FloatConversion.h` header. Reviewed By: excelle08 Differential Revision: D68042072
|
This pull request was exported from Phabricator. Differential Revision: D68042072 |
|
This pull request was exported from Phabricator. Differential Revision: D68042072 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: There is a lot of inline code in
Types.hfor converting between different floating point types and I am about to add even more. However most users of this header are only interested in thefloat16, etc. type definitions but don't use the conversions. It seems like a good idea to move the conversion code to a separateFloatConversion.hheader.Reviewed By: excelle08
Differential Revision: D68042072