-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backout Unifying TBE API using List (Frontend) #3803
Closed
Closed
+317
−346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D70996903 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
spcyppt
added a commit
to spcyppt/torchrec
that referenced
this pull request
Mar 11, 2025
Summary: X-link: pytorch/FBGEMM#3803 X-link: facebookresearch/FBGEMM#887 Backout D68055168 as it seems to break pyper and causes S498612. Differential Revision: D70996903
spcyppt
added a commit
to spcyppt/torchrec
that referenced
this pull request
Mar 11, 2025
Summary: X-link: pytorch/FBGEMM#3803 X-link: facebookresearch/FBGEMM#887 Backout D68055168 as it seems to break pyper and causes S498612. Reviewed By: nautsimon Differential Revision: D70996903
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Mar 11, 2025
Summary: X-link: pytorch/torchrec#2799 X-link: facebookresearch/FBGEMM#887 Backout D68055168 as it seems to break pyper and causes S498612. Reviewed By: nautsimon Differential Revision: D70996903
f1fe624
to
87bb166
Compare
spcyppt
added a commit
to spcyppt/torchrec
that referenced
this pull request
Mar 11, 2025
Summary: X-link: pytorch/FBGEMM#3803 X-link: facebookresearch/FBGEMM#887 Backout D68055168 as it seems to break pyper and causes S498612. Reviewed By: sryap, nautsimon Differential Revision: D70996903
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Mar 11, 2025
Summary: X-link: pytorch/torchrec#2799 X-link: facebookresearch/FBGEMM#887 Backout D68055168 as it seems to break pyper and causes S498612. Reviewed By: sryap, nautsimon Differential Revision: D70996903
87bb166
to
58a16d6
Compare
This pull request was exported from Phabricator. Differential Revision: D70996903 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Mar 11, 2025
Summary: X-link: pytorch/torchrec#2799 Pull Request resolved: pytorch#3803 X-link: facebookresearch/FBGEMM#887 Backout D68055168 as it seems to break pyper and causes S498612. Reviewed By: sryap, nautsimon Differential Revision: D70996903
58a16d6
to
1ca2201
Compare
spcyppt
added a commit
to spcyppt/torchrec
that referenced
this pull request
Mar 11, 2025
Summary: Pull Request resolved: pytorch#2799 X-link: pytorch/FBGEMM#3803 X-link: facebookresearch/FBGEMM#887 Backout D68055168 as it seems to break pyper and causes S498612. Reviewed By: sryap, nautsimon Differential Revision: D70996903
Summary: X-link: pytorch/torchrec#2799 Pull Request resolved: pytorch#3803 X-link: facebookresearch/FBGEMM#887 Backout D68055168 as it seems to break pyper and causes S498612. Reviewed By: sryap, nautsimon Differential Revision: D70996903
This pull request was exported from Phabricator. Differential Revision: D70996903 |
1ca2201
to
e3ce7bf
Compare
This pull request has been merged in ce8bc21. |
facebook-github-bot
pushed a commit
to pytorch/torchrec
that referenced
this pull request
Mar 12, 2025
Summary: Pull Request resolved: #2799 X-link: pytorch/FBGEMM#3803 X-link: facebookresearch/FBGEMM#887 Backout D68055168 as it seems to break pyper and causes S498612. Reviewed By: c00w, sryap, nautsimon Differential Revision: D70996903 fbshipit-source-id: 196088a7f5bc0bc3c129dcf1af9a55d83d892eed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/887
Backout D68055168 as it seems to break pyper and causes S498612.
Differential Revision: D70996903