Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backout Unifying TBE API using List (Frontend) #3803

Closed
wants to merge 1 commit into from

Conversation

spcyppt
Copy link
Contributor

@spcyppt spcyppt commented Mar 11, 2025

Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/887

Backout D68055168 as it seems to break pyper and causes S498612.

Differential Revision: D70996903

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70996903

Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit e3ce7bf
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/67d0bc0139db450008c8fb4a
😎 Deploy Preview https://deploy-preview-3803--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

spcyppt added a commit to spcyppt/torchrec that referenced this pull request Mar 11, 2025
Summary:
X-link: pytorch/FBGEMM#3803

X-link: facebookresearch/FBGEMM#887

Backout D68055168 as it seems to break pyper and causes S498612.

Differential Revision: D70996903
@spcyppt spcyppt mentioned this pull request Mar 11, 2025
spcyppt added a commit to spcyppt/torchrec that referenced this pull request Mar 11, 2025
Summary:

X-link: pytorch/FBGEMM#3803

X-link: facebookresearch/FBGEMM#887

Backout D68055168 as it seems to break pyper and causes S498612.

Reviewed By: nautsimon

Differential Revision: D70996903
spcyppt added a commit to spcyppt/FBGEMM that referenced this pull request Mar 11, 2025
Summary:
X-link: pytorch/torchrec#2799


X-link: facebookresearch/FBGEMM#887

Backout D68055168 as it seems to break pyper and causes S498612.

Reviewed By: nautsimon

Differential Revision: D70996903
spcyppt added a commit to spcyppt/torchrec that referenced this pull request Mar 11, 2025
Summary:

X-link: pytorch/FBGEMM#3803

X-link: facebookresearch/FBGEMM#887

Backout D68055168 as it seems to break pyper and causes S498612.

Reviewed By: sryap, nautsimon

Differential Revision: D70996903
spcyppt added a commit to spcyppt/FBGEMM that referenced this pull request Mar 11, 2025
Summary:
X-link: pytorch/torchrec#2799


X-link: facebookresearch/FBGEMM#887

Backout D68055168 as it seems to break pyper and causes S498612.

Reviewed By: sryap, nautsimon

Differential Revision: D70996903
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70996903

spcyppt added a commit to spcyppt/FBGEMM that referenced this pull request Mar 11, 2025
Summary:
X-link: pytorch/torchrec#2799

Pull Request resolved: pytorch#3803

X-link: facebookresearch/FBGEMM#887

Backout D68055168 as it seems to break pyper and causes S498612.

Reviewed By: sryap, nautsimon

Differential Revision: D70996903
spcyppt added a commit to spcyppt/torchrec that referenced this pull request Mar 11, 2025
Summary:
Pull Request resolved: pytorch#2799

X-link: pytorch/FBGEMM#3803

X-link: facebookresearch/FBGEMM#887

Backout D68055168 as it seems to break pyper and causes S498612.

Reviewed By: sryap, nautsimon

Differential Revision: D70996903
Summary:
X-link: pytorch/torchrec#2799

Pull Request resolved: pytorch#3803

X-link: facebookresearch/FBGEMM#887

Backout D68055168 as it seems to break pyper and causes S498612.

Reviewed By: sryap, nautsimon

Differential Revision: D70996903
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70996903

@spcyppt spcyppt changed the title Backout Backout Unifying TBE API using List (Frontend) Mar 11, 2025
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ce8bc21.

facebook-github-bot pushed a commit to pytorch/torchrec that referenced this pull request Mar 12, 2025
Summary:
Pull Request resolved: #2799

X-link: pytorch/FBGEMM#3803

X-link: facebookresearch/FBGEMM#887

Backout D68055168 as it seems to break pyper and causes S498612.

Reviewed By: c00w, sryap, nautsimon

Differential Revision: D70996903

fbshipit-source-id: 196088a7f5bc0bc3c129dcf1af9a55d83d892eed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants