Skip to content

Handle non-UTF-8 metadata in audio file stream info #4174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mr-Neutr0n wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle non-UTF-8 metadata in audio file stream info #4174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/torchaudio/_torchcodec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,13 +112,25 @@ def load_with_torchcodec(
warnings.warn("The 'format' parameter is not supported by TorchCodec AudioDecoder.", UserWarning, stacklevel=2)

# Create AudioDecoder
# Some audio files (e.g. Opus from MLS dataset) contain metadata
# with non-UTF-8 bytes, which can cause UnicodeDecodeError during
# initialization or when accessing stream metadata.
try:
decoder = AudioDecoder(uri)
except UnicodeDecodeError as e:
raise RuntimeError(
f"Failed to create AudioDecoder for {uri}: "
f"file metadata contains non-decodable bytes: {e}"
) from e
except Exception as e:
raise RuntimeError(f"Failed to create AudioDecoder for {uri}: {e}") from e

# Get sample rate from metadata
sample_rate = decoder.metadata.sample_rate
# Get sample rate from metadata.
# Guard against UnicodeDecodeError from non-UTF-8 metadata tags.
try:
sample_rate = decoder.metadata.sample_rate
except UnicodeDecodeError:
sample_rate = None
if sample_rate is None:
raise RuntimeError("Unable to determine sample rate from audio metadata")

Expand Down