Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding controlnet #1164

Closed
wants to merge 3 commits into from
Closed

[WIP] Adding controlnet #1164

wants to merge 3 commits into from

Conversation

arunppsg
Copy link

#1131

This pull request adds a new example of controlnet model in pytorch.

@netlify
Copy link

netlify bot commented Jun 11, 2023

Deploy Preview for pytorch-examples-preview canceled.

Name Link
🔨 Latest commit b0555f7
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-examples-preview/deploys/648601bdfbf28e000789d1c4

@msaroufim
Copy link
Member

Hi @arunppsg are you still interested in merging this? I think you're close

@arunppsg
Copy link
Author

The original controlnet model is big and I am not able to test it in my machine. I also need to add a couple of more components to the model. I have a question: Should we make a small minimal implementation, like min-GPT or do an implementation of full model? I think the former approach will be good for an example and latter one is already available at ControlNet.

@msaroufim
Copy link
Member

Minimal is usually better for this repo

@arunppsg
Copy link
Author

Sounds good, I will work on making a minimal prototype by end of Aug.

@arunppsg arunppsg closed this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants