Skip to content

[3/N] Add update function in backend interface #11391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: gh/cccclai/23/base
Choose a base branch
from
Open

[3/N] Add update function in backend interface #11391

wants to merge 3 commits into from
+318 −0

Conversation

cccclai
Copy link
Contributor

@cccclai cccclai commented Jun 5, 2025 •
edited
Loading

@cccclai
[3/N] Add update function in backend interface
c4a952a 
Add update function in backend interface class.

Next step, will add update API in the method and then module

Differential Revision: [D75919242](https://our.internmc.facebook.com/intern/diff/D75919242/)

[ghstack-poisoned]
This was referenced Jun 5, 2025
Open
Open
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11391

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit ea2d27b with merge base ef1d2ff (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

cccclai added a commit that referenced this pull request Jun 5, 2025
@cccclai
[3/N] Add update function in backend interface
c25128c 
Add update function in backend interface class.

Next step, will add update API in the method and then module

Differential Revision: [D75919242](https://our.internmc.facebook.com/intern/diff/D75919242/)

ghstack-source-id: 288333606
Pull Request resolved: #11391
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 5, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75919242

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

kimishpatel
kimishpatel reviewed Jun 6, 2025
View reviewed changes
runtime/backend/backend_options.h
@@ -117,6 +118,10 @@ class BackendOptions {
return err;
}

executorch::runtime::ArrayRef<BackendOption> view() const {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe more meaningful name. get_backend_options or get_ref_to_backend_options

@cccclai
Update on "[3/N] Add update function in backend interface"
f2249b3 
Add update function in backend interface class.

Next step, will add update API in the method and then module

Differential Revision: [D75919242](https://our.internmc.facebook.com/intern/diff/D75919242/)

[ghstack-poisoned]
This was referenced Jun 6, 2025
Open
Open
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75919242

@cccclai
Update on "[3/N] Add update function in backend interface"
ea2d27b 
Add update function in backend interface class.

Next step, will add update API in the method and then module

Differential Revision: [D75919242](https://our.internmc.facebook.com/intern/diff/D75919242/)

[ghstack-poisoned]
This was referenced Jun 10, 2025
Open
Open
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75919242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimishpatel kimishpatel kimishpatel left review comments

@digantdesai digantdesai Awaiting requested review from digantdesai

@mergennachin mergennachin Awaiting requested review from mergennachin

@SS-JIA SS-JIA Awaiting requested review from SS-JIA

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka

@mcr229 mcr229 Awaiting requested review from mcr229

@metascroy metascroy Awaiting requested review from metascroy

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cccclai @facebook-github-bot @kimishpatel