[3/N] Add update function in backend interface #11391

cccclai · 2025-06-05T04:15:13Z

Stack from ghstack (oldest at bottom):

Add update function in backend interface class.

Next step, will add update API in the method and then module

Differential Revision: D75919242

Add update function in backend interface class. Next step, will add update API in the method and then module Differential Revision: [D75919242](https://our.internmc.facebook.com/intern/diff/D75919242/) [ghstack-poisoned]

pytorch-bot · 2025-06-05T04:15:17Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11391

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit efa67f3 with merge base f7cc72f ():

NEW FAILURE - The following job has failed:

Lint / lintrunner / linux-job (gh)
>>> Lint for runtime/backend/test/backend_interface_update_test.cpp:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / unittest / linux / linux-job (gh) (trunk failure)
.ci/scripts/tests/test_gather_benchmark_configs.py::TestGatehrBenchmarkConfigs::test_generate_compatible_configs_quantized_llama_model
pull / unittest-editable / linux / linux-job (gh) (trunk failure)
.ci/scripts/tests/test_gather_benchmark_configs.py::TestGatehrBenchmarkConfigs::test_generate_compatible_configs_quantized_llama_model

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Add update function in backend interface class. Next step, will add update API in the method and then module Differential Revision: [D75919242](https://our.internmc.facebook.com/intern/diff/D75919242/) ghstack-source-id: 288333606 Pull Request resolved: #11391

facebook-github-bot · 2025-06-05T04:15:32Z

This pull request was exported from Phabricator. Differential Revision: D75919242

github-actions · 2025-06-05T04:16:04Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

kimishpatel · 2025-06-06T02:31:50Z

runtime/backend/backend_options.h

@@ -117,6 +118,10 @@ class BackendOptions {
    return err;
  }

+  executorch::runtime::ArrayRef<BackendOption> view() const {


maybe more meaningful name. get_backend_options or get_ref_to_backend_options

Add update function in backend interface class. Next step, will add update API in the method and then module Differential Revision: [D75919242](https://our.internmc.facebook.com/intern/diff/D75919242/) [ghstack-poisoned]

facebook-github-bot · 2025-06-06T23:50:32Z

This pull request was exported from Phabricator. Differential Revision: D75919242

Add update function in backend interface class. Next step, will add update API in the method and then module Differential Revision: [D75919242](https://our.internmc.facebook.com/intern/diff/D75919242/) [ghstack-poisoned]

facebook-github-bot · 2025-06-10T18:40:24Z

This pull request was exported from Phabricator. Differential Revision: D75919242

Add update function in backend interface class. Next step, will add update API in the method and then module Differential Revision: [D75919242](https://our.internmc.facebook.com/intern/diff/D75919242/) [ghstack-poisoned]

facebook-github-bot · 2025-06-12T21:36:55Z

This pull request was exported from Phabricator. Differential Revision: D75919242

kimishpatel · 2025-06-13T03:01:34Z

runtime/backend/interface.h

+   * @param[in] args A list of BackendOptions passed in by users.
+   * @retval Error::Ok if successful.
+   */
+   ET_NODISCARD virtual Error update(


I would jsut call it set_backend_options which seems more appropriate

I kind of like this API name more, but we can discuss about it.

kimishpatel · 2025-06-13T03:02:10Z

runtime/backend/interface.h

+    BackendUpdateContext& context,
+    const executorch::runtime::ArrayRef<BackendOption>& backend_options) const {
+        return Error::Ok;
+      };


what is the implementation of this? If it is in the next diff, can you pull it here?

It's the base function. If backends didn't implement this function, this function will be called. If we set it to virtual, then we need all backends to implement this fucntion.

kimishpatel · 2025-06-13T03:02:26Z

runtime/backend/interface.h

+   * @retval Error::Ok if successful.
+   */
+   ET_NODISCARD virtual Error update(
+    BackendUpdateContext& context,


what is supposed to be the role of BackendUpdateContext?

It's a place holder for future API changes. Currently have the context for init and execute

kimishpatel · 2025-06-13T03:05:09Z

runtime/backend/test/backend_interface_update_test.cpp

+  BackendOptions<5> options;  
+};
+
+TEST_F(BackendInterfaceUpdateTest, HandlesInvalidOption) {


There are all these tests but I am not sure if they are meanigfully testing anything? do you need all of them?

I think it's helpful to make sure we know each option inside the backend is updated successfully, and they are isolated.

[3/N] Add update function in backend interface

c4a952a

Add update function in backend interface class. Next step, will add update API in the method and then module Differential Revision: [D75919242](https://our.internmc.facebook.com/intern/diff/D75919242/) [ghstack-poisoned]

This was referenced Jun 5, 2025

[1/N] Add BackendOptions class #11389

Open

[2/N] Add update context #11390

Open

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 5, 2025

facebook-github-bot added the fb-exported label Jun 5, 2025

cccclai requested review from digantdesai, mergennachin, SS-JIA, kimishpatel, JacobSzwejbka, mcr229 and metascroy June 5, 2025 04:57

kimishpatel reviewed Jun 6, 2025

View reviewed changes

Update on "[3/N] Add update function in backend interface"

f2249b3

Add update function in backend interface class. Next step, will add update API in the method and then module Differential Revision: [D75919242](https://our.internmc.facebook.com/intern/diff/D75919242/) [ghstack-poisoned]

This was referenced Jun 6, 2025

[4/N] Add backend options map #11462

Open

[5/N] Add update in method #11463

Open

Update on "[3/N] Add update function in backend interface"

ea2d27b

Add update function in backend interface class. Next step, will add update API in the method and then module Differential Revision: [D75919242](https://our.internmc.facebook.com/intern/diff/D75919242/) [ghstack-poisoned]

This was referenced Jun 10, 2025

[6/N] Add update in module #11533

Open

[7/N] Add sugar syntax for module.update #11534

Open

Update on "[3/N] Add update function in backend interface"

efa67f3

Add update function in backend interface class. Next step, will add update API in the method and then module Differential Revision: [D75919242](https://our.internmc.facebook.com/intern/diff/D75919242/) [ghstack-poisoned]

kimishpatel reviewed Jun 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[3/N] Add update function in backend interface #11391

[3/N] Add update function in backend interface #11391

Uh oh!

cccclai commented Jun 5, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Jun 5, 2025 •

edited

Loading

Uh oh!

facebook-github-bot commented Jun 5, 2025

Uh oh!

github-actions bot commented Jun 5, 2025

Uh oh!

kimishpatel Jun 6, 2025

Uh oh!

facebook-github-bot commented Jun 6, 2025

Uh oh!

facebook-github-bot commented Jun 10, 2025

Uh oh!

facebook-github-bot commented Jun 12, 2025

Uh oh!

kimishpatel Jun 13, 2025

Uh oh!

cccclai Jun 13, 2025

Uh oh!

kimishpatel Jun 13, 2025

Uh oh!

cccclai Jun 13, 2025

Uh oh!

kimishpatel Jun 13, 2025

Uh oh!

cccclai Jun 13, 2025

Uh oh!

kimishpatel Jun 13, 2025

Uh oh!

cccclai Jun 13, 2025

Uh oh!

Uh oh!

[3/N] Add update function in backend interface #11391

Are you sure you want to change the base?

[3/N] Add update function in backend interface #11391

Uh oh!

Conversation

cccclai commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11391

❌ 1 New Failure, 2 Unrelated Failures

Uh oh!

facebook-github-bot commented Jun 5, 2025

Uh oh!

github-actions bot commented Jun 5, 2025

This PR needs a release notes: label

Uh oh!

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Jun 6, 2025

Uh oh!

facebook-github-bot commented Jun 10, 2025

Uh oh!

facebook-github-bot commented Jun 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cccclai commented Jun 5, 2025 •

edited

Loading

pytorch-bot bot commented Jun 5, 2025 •

edited

Loading

This PR needs a `release notes:` label