Skip to content

Create a function to check if dependent flags are ON #11455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented Jun 6, 2025

Summary

Some flags require other flags to also be turned on. So this function helps use enforce it.

Test plan

Used in: #11457

$ python -m unittest tools.cmake.common.preset_test.TestPreset

cc @larryliu0820

@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: none Do not include this in the release notes labels Jun 6, 2025
Copy link

pytorch-bot bot commented Jun 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11455

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 7 Pending

As of commit e8aec99 with merge base 224d4b7 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2025
@jathu jathu force-pushed the jathu/cmake-required-flags branch from 3b50db6 to 28bcb5d Compare June 6, 2025 20:26
@jathu jathu force-pushed the jathu/cmake-required-flags branch from 28bcb5d to e8aec99 Compare June 6, 2025 21:11
@jathu jathu marked this pull request as ready for review June 6, 2025 21:33
@jathu jathu merged commit b632906 into main Jun 6, 2025
93 of 96 checks passed
@jathu jathu deleted the jathu/cmake-required-flags branch June 6, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants