Configure conflicting ARM baremetal cmake flags#11493
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11493
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 8ce3d08 with merge base ce48e0d ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cae4da2 to
2a2cf98
Compare
2a2cf98 to
8ce3d08
Compare
|
Thanks, if this combination don't work we should try to fix it :) |
The ARM size test builds with EXECUTORCH_BUILD_ARM_BAREMETAL, and size_test.cpp requires FileDataLoader (and, currently, incorrectly doesn't enable it). Is it OK to remove this constraint? |
|
@swolchok I'm not sure, you can try it. I tried retaining the existing behavior where |
Summary
Similar to #11457, but now we also want to warn against unsupported/conflicting flags. For example, when using
EXECUTORCH_BUILD_ARM_BAREMETAL, we cannot enable certain flags.Test plan
CI
cc @larryliu0820 @digantdesai @freddan80 @per @zingo @oscarandersson8218