Add required_for_abi_source_only = True to extension/android:executorch_llama
#12093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orch_llama Summary: [Buck's document on Java source ABI](https://buck.build/concept/java_abis.html) recommends adding `required_for_source_abi = True` to targets that export annotations: > ... All annotations and compile-time constants (including enum values) used in the interface of a rule must be present during source-only ABI generation. > The error will suggest adding required_for_source_abi = True to any rule that defines an annotation type or a compile-time constant that is used from another rule, ... Differential Revision: D77479748
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12093
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 967ea2f with merge base db8ef6b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77479748 |
|
@pytorchbot label "release notes: build" |
pytorch-bot
bot
added
the
release notes: build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Buck's document on Java source ABI recommends adding
required_for_source_abi = Trueto targets that export annotations:Differential Revision: D77479748