Skip to content

Parallelize optimized op_log_softmax #12099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gh/swolchok/486/base
Choose a base branch
from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Jun 30, 2025

Stack from ghstack (oldest at bottom):

Straightforward application of parallel_for.

Differential Revision: D76831122

Straightforward application of parallel_for.

Differential Revision: [D76831122](https://our.internmc.facebook.com/intern/diff/D76831122/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jun 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12099

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit a04da54 with merge base cf0bfd2 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jun 30, 2025
Straightforward application of parallel_for.

Differential Revision: [D76831122](https://our.internmc.facebook.com/intern/diff/D76831122/)

ghstack-source-id: 293375210
Pull Request resolved: #12099
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 30, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76831122

@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Jun 30, 2025
@swolchok
Copy link
Contributor Author

pull / android / run-emulator is consistently telling us this is broken, but the bug is not obvious to me on rereading

@swolchok
Copy link
Contributor Author

after rereading the code twice, I was inclined to suspect that the kernel is somehow thread-unsafe, so I built with TSAN locally (-fsanitize=debug, CMAKE_BUILD_TYPE=RelWithDebInfo so parallel_for will actually parallelize) and didn't catch a failure. doesn't look like a pre-existing issue on HUD or anything so we shouldn't bypass, but I'm not sure what to do next. Nobody is particularly asking for parallelization AFAIK so there's no rush...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: ops & kernels Changes to the opset and any new / changed kernel implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants