Add null pointer check for evalues (#14749) #16162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16162
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit d3d3e28 with merge base e804065 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
rascani
added a commit
to rascani/executorch
that referenced
this pull request
Dec 9, 2025
Summary: The to* functions could de-reference a NULL pointer. Adding a check. Reviewed By: mergennachin Differential Revision: D83742246
rascani
force-pushed
the
export-D83742246
branch
from
ffcd6d8 to
abdb23a
Compare
rascani
added a commit
to rascani/executorch
that referenced
this pull request
Dec 9, 2025
Summary: The to* functions could de-reference a NULL pointer. Adding a check. Reviewed By: mergennachin Differential Revision: D83742246
rascani
force-pushed
the
export-D83742246
branch
from
abdb23a to
f02c12b
Compare
larryliu0820
approved these changes
Dec 9, 2025
rascani
added a commit
to rascani/executorch
that referenced
this pull request
Dec 9, 2025
Summary: The to* functions could de-reference a NULL pointer. Adding a check. Reviewed By: larryliu0820, mergennachin Differential Revision: D83742246
rascani
force-pushed
the
export-D83742246
branch
from
f02c12b to
046e816
Compare
rascani
added a commit
to rascani/executorch
that referenced
this pull request
Dec 9, 2025
Summary: The to* functions could de-reference a NULL pointer. Adding a check. Reviewed By: larryliu0820, mergennachin Differential Revision: D83742246
rascani
force-pushed
the
export-D83742246
branch
from
046e816 to
0bdc306
Compare
rascani
added a commit
to rascani/executorch
that referenced
this pull request
Dec 9, 2025
Summary: The to* functions could de-reference a NULL pointer. Adding a check. Reviewed By: larryliu0820, mergennachin Differential Revision: D83742246
rascani
force-pushed
the
export-D83742246
branch
from
0bdc306 to
81bf0d3
Compare
rascani
added a commit
to rascani/executorch
that referenced
this pull request
Dec 9, 2025
Summary: The to* functions could de-reference a NULL pointer. Adding a check. Reviewed By: larryliu0820, mergennachin Differential Revision: D83742246
rascani
force-pushed
the
export-D83742246
branch
from
81bf0d3 to
d13cece
Compare
Summary: The to* functions could de-reference a NULL pointer. Adding a check. Reviewed By: larryliu0820, mergennachin Differential Revision: D83742246
rascani
force-pushed
the
export-D83742246
branch
from
d13cece to
d3d3e28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The to* functions could de-reference a NULL pointer. Adding a check.
Reviewed By: mergennachin
Differential Revision: D83742246