Skip to content

Conversation

@sxu
Copy link
Contributor

@sxu sxu commented Dec 9, 2025

Summary: Prefill will produce the logits at position 0 when not generating full logits. Lookahead decoding requires full logits.

Differential Revision: D88790445

@sxu sxu requested review from jackzhxng and lucylq as code owners December 9, 2025 23:52
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16171

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 38fada4 with merge base 5033840 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 9, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 9, 2025

@sxu has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88790445.

@sxu sxu requested a review from billmguo December 9, 2025 23:54
@sxu sxu added the release notes: none Do not include this in the release notes label Dec 9, 2025
@sxu sxu force-pushed the export-D88790445 branch from 9c3ae40 to 166d439 Compare December 11, 2025 01:41
sxu added a commit to sxu/executorch that referenced this pull request Dec 11, 2025
…ch#16171)

Summary:

Prefill will produce the logits at position 0 when not generating full logits. Lookahead decoding requires full logits.

Reviewed By: billmguo

Differential Revision: D88790445
sxu added a commit to sxu/executorch that referenced this pull request Dec 11, 2025
…ch#16171)

Summary:

Prefill will produce the logits at position 0 when not generating full logits. Lookahead decoding requires full logits.

Reviewed By: billmguo

Differential Revision: D88790445
@sxu sxu force-pushed the export-D88790445 branch from 166d439 to 927c8d5 Compare December 11, 2025 03:49
sxu added a commit to sxu/executorch that referenced this pull request Dec 11, 2025
…ch#16171)

Summary:

Prefill will produce the logits at position 0 when not generating full logits. Lookahead decoding requires full logits.

Reviewed By: billmguo

Differential Revision: D88790445
@sxu sxu force-pushed the export-D88790445 branch from 927c8d5 to cc1750b Compare December 11, 2025 18:35
…ch#16171)

Summary:

Prefill will produce the logits at position 0 when not generating full logits. Lookahead decoding requires full logits.

Reviewed By: billmguo

Differential Revision: D88790445
@sxu sxu force-pushed the export-D88790445 branch from cc1750b to 38fada4 Compare December 11, 2025 18:57
@meta-codesync meta-codesync bot merged commit b3c44c9 into pytorch:main Dec 11, 2025
224 of 228 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants