Skip to content

Rename build files from TARGETS to BUCK (group ID: -1524544273800567572) (#19414)#19414

Open
bigfootjon wants to merge 1 commit intomainfrom
export-D104415545
Open

Rename build files from TARGETS to BUCK (group ID: -1524544273800567572) (#19414)#19414
bigfootjon wants to merge 1 commit intomainfrom
export-D104415545

Conversation

@bigfootjon
Copy link
Copy Markdown
Member

@bigfootjon bigfootjon commented May 8, 2026

Summary: Pull Request resolved: #19414

Reviewed By: bigfootjon

Differential Revision: D104415545

Copilot AI review requested due to automatic review settings May 8, 2026 23:03
@bigfootjon bigfootjon requested a review from JacobSzwejbka as a code owner May 8, 2026 23:03
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 8, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19414

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit cc62981 with merge base 4413a5c (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 8, 2026

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104415545.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames/migrates Buck build definitions by moving targets from TARGETS to BUCK and wrapping target declarations with migration macros to support fbcode vs non-fbcode environments.

Changes:

  • Convert extension/audio/BUCK targets to use fbcode_target wrappers.
  • Remove extension/aten_util/test/TARGETS and merge its intent into extension/aten_util/test/BUCK.
  • Introduce fbcode_target/non_fbcode_target wrappers in extension/aten_util/test/BUCK to conditionally define common targets.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
extension/audio/BUCK Wrap existing python targets using migration macros for fbcode/non-fbcode handling.
extension/aten_util/test/TARGETS Remove legacy TARGETS entrypoint now that definitions are merged into BUCK.
extension/aten_util/test/BUCK Add migration wrappers and merge prior TARGETS guidance/callsite into BUCK.
Comments suppressed due to low confidence (1)

extension/audio/BUCK:1

  • non_fbcode_target is loaded here but never used in this file. Consider removing it from the load(...) (or wrapping targets that should exist in non-fbcode builds with non_fbcode_target) to avoid unused/ambiguous migration imports.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +16 to +18
load(":targets.bzl", "define_common_targets")


Comment on lines +11 to +15
# !!!! fbcode/executorch/extension/aten_util/test/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!!

# Any targets that should be shared between fbcode and xplat must be defined in
# targets.bzl. This file can contain fbcode-only targets.

…72) (#19414)

Summary: Pull Request resolved: #19414

Reviewed By: bigfootjon

Differential Revision: D104415545
@meta-codesync meta-codesync Bot changed the title Rename build files from TARGETS to BUCK (group ID: -1524544273800567572) Rename build files from TARGETS to BUCK (group ID: -1524544273800567572) (#19414) May 9, 2026
@bigfootjon bigfootjon force-pushed the export-D104415545 branch from aeed8f9 to cc62981 Compare May 9, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants