Skip to content

Rename build files from TARGETS to BUCK (group ID: -1179671466944197245) (#19416)#19416

Open
bigfootjon wants to merge 1 commit intomainfrom
export-D104414920
Open

Rename build files from TARGETS to BUCK (group ID: -1179671466944197245) (#19416)#19416
bigfootjon wants to merge 1 commit intomainfrom
export-D104414920

Conversation

@bigfootjon
Copy link
Copy Markdown
Member

@bigfootjon bigfootjon commented May 8, 2026 •
edited by meta-codesync Bot
Loading

Summary: Pull Request resolved: #19416

Reviewed By: bigfootjon

Differential Revision: D104414920

@bigfootjon bigfootjon requested a review from SS-JIA as a code owner May 8, 2026 23:20
Copilot AI review requested due to automatic review settings May 8, 2026 23:20
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 8, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19416

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures

As of commit 5d35efa with merge base 4413a5c (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 8, 2026

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104414920.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot AI reviewed May 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates Vulkan backend Buck build definitions from legacy TARGETS files into BUCK files, using build_file_migration.bzl wrappers to distinguish fbcode vs non-fbcode targets.

Changes:

  • Removed TARGETS files under backends/vulkan/test/** and merged their definitions into corresponding BUCK files.
  • Introduced fbcode_target / non_fbcode_target wrappers for shared build-file migration.
  • Updated Vulkan passes BUCK targets to be wrapped with fbcode_target.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
backends/vulkan/test/TARGETS Deleted; fbcode Python test targets migrated into backends/vulkan/test/BUCK.
backends/vulkan/test/op_tests/TARGETS Deleted; fbcode invocation migrated into backends/vulkan/test/op_tests/BUCK.
backends/vulkan/test/op_tests/BUCK Added; wraps common targets for fbcode vs non-fbcode.
backends/vulkan/test/custom_ops/TARGETS Deleted; fbcode invocation migrated into backends/vulkan/test/custom_ops/BUCK.
backends/vulkan/test/custom_ops/BUCK Added; wraps common targets for fbcode vs non-fbcode.
backends/vulkan/test/BUCK Updated; now hosts both non-fbcode compute API targets and fbcode Python unittests.
backends/vulkan/_passes/BUCK Updated; wraps existing python_library targets with fbcode_target.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread backends/vulkan/test/BUCK
Comment on lines +18 to +22
# !!!! fbcode/executorch/backends/vulkan/test/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!!

load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest")
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")

Comment thread backends/vulkan/test/op_tests/BUCK
Comment on lines +2 to 6
oncall("executorch")
# Any targets that should be shared between fbcode and xplat must be defined in
# targets.bzl. This file can contain xplat-only targets.

load(":targets.bzl", "define_common_targets")
Comment thread backends/vulkan/test/custom_ops/BUCK
Comment on lines +2 to 6
oncall("executorch")
# Any targets that should be shared between fbcode and xplat must be defined in
# targets.bzl. This file can contain xplat-only targets.

load(":targets.bzl", "define_common_targets")
@meta-codesync
Rename build files from TARGETS to BUCK (group ID: -11796714669441972…
5d35efa 
…45) (#19416)

Summary: Pull Request resolved: #19416

Reviewed By: bigfootjon

Differential Revision: D104414920
@bigfootjon bigfootjon force-pushed the export-D104414920 branch from 749cd5a to 5d35efa Compare May 9, 2026 01:12
@meta-codesync meta-codesync Bot changed the title Rename build files from TARGETS to BUCK (group ID: -1179671466944197245) Rename build files from TARGETS to BUCK (group ID: -1179671466944197245) (#19416) May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@SS-JIA SS-JIA Awaiting requested review from SS-JIA SS-JIA is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bigfootjon