Skip to content

Rename build files from TARGETS to BUCK (group ID: 1842302970244970417) (#19428)#19428

Open
bigfootjon wants to merge 1 commit intomainfrom
export-D104415000
Open

Rename build files from TARGETS to BUCK (group ID: 1842302970244970417) (#19428)#19428
bigfootjon wants to merge 1 commit intomainfrom
export-D104415000

Conversation

@bigfootjon
Copy link
Copy Markdown
Member

@bigfootjon bigfootjon commented May 8, 2026

Summary: Pull Request resolved: #19428

Reviewed By: bigfootjon

Differential Revision: D104415000

Copilot AI review requested due to automatic review settings May 8, 2026 23:21
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 8, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19428

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Pending

As of commit 8032e69 with merge base 4413a5c (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 8, 2026

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104415000.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates several backend build definitions to the BUCK build-file migration pattern by wrapping targets with fbcode_target / non_fbcode_target, and merges the MediaTek runtime TARGETS content into BUCK.

Changes:

  • Add build_file_migration.bzl wrappers and convert existing targets to fbcode_target/non_fbcode_target.
  • Merge backends/mediatek/runtime/TARGETS into backends/mediatek/runtime/BUCK.
  • Apply the same wrapper conversion for example and CUDA test targets.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
backends/mediatek/runtime/TARGETS Removed/merged into the corresponding BUCK file as part of the TARGETS→BUCK migration.
backends/mediatek/runtime/BUCK Adds migration wrappers and wraps the neuron_backend cxx library as a non-fbcode target.
backends/mediatek/quantizer/BUCK Wraps the quantizer python library with fbcode_target for migration.
backends/example/BUCK Wraps example python libraries and unittest target with fbcode_target.
backends/cuda/tests/BUCK Wraps CUDA test targets with fbcode_target for migration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 1 to 10
@@ -7,9 +9,8 @@ load(
)
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
visibility = ["PUBLIC"],
)

# !!!! fbcode/executorch/backends/mediatek/runtime/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!!
…7) (#19428)

Summary: Pull Request resolved: #19428

Reviewed By: bigfootjon

Differential Revision: D104415000
@meta-codesync meta-codesync Bot changed the title Rename build files from TARGETS to BUCK (group ID: 1842302970244970417) Rename build files from TARGETS to BUCK (group ID: 1842302970244970417) (#19428) May 9, 2026
@bigfootjon bigfootjon force-pushed the export-D104415000 branch from 74bc975 to 8032e69 Compare May 9, 2026 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants