Skip to content

Rename build files from TARGETS to BUCK (group ID: -5056067471429134516) (#19430)#19430

Open
bigfootjon wants to merge 1 commit intomainfrom
export-D104414843
Open

Rename build files from TARGETS to BUCK (group ID: -5056067471429134516) (#19430)#19430
bigfootjon wants to merge 1 commit intomainfrom
export-D104414843

Conversation

@bigfootjon
Copy link
Copy Markdown
Member

@bigfootjon bigfootjon commented May 8, 2026

Summary: Pull Request resolved: #19430

Reviewed By: bigfootjon

Differential Revision: D104414843

Copilot AI review requested due to automatic review settings May 8, 2026 23:22
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 8, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19430

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit a5c83e5 with merge base 93b764e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 8, 2026

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104414843.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the Buck build-file migration by renaming several TARGETS files to BUCK in the AOTI SlimTensor areas, and updating the AOTI test BUCK file to use the migration wrapper macro.

Changes:

  • Replace direct cpp_unittest(...) invocations with fbcode_target(_kind = cpp_unittest, ...) in backends/aoti/tests/BUCK.
  • Remove TARGETS stubs that only invoked define_common_targets(), replacing them with equivalent BUCK files invoking fbcode_target(_kind = define_common_targets,).
  • Standardize these BUCK files to load build_file_migration.bzl alongside the local targets.bzl.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
backends/aoti/tests/BUCK Wrap AOTI unit test targets with fbcode_target for the migration pattern.
backends/aoti/slim/util/test/TARGETS Remove legacy TARGETS stub (migration to BUCK).
backends/aoti/slim/util/test/BUCK Add BUCK calling define_common_targets via fbcode_target.
backends/aoti/slim/util/TARGETS Remove legacy TARGETS stub (migration to BUCK).
backends/aoti/slim/util/BUCK Add BUCK calling define_common_targets via fbcode_target.
backends/aoti/slim/factory/test/TARGETS Remove legacy TARGETS stub (migration to BUCK).
backends/aoti/slim/factory/test/BUCK Add BUCK calling define_common_targets via fbcode_target.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…16) (#19430)

Summary: Pull Request resolved: #19430

Reviewed By: bigfootjon

Differential Revision: D104414843
@meta-codesync meta-codesync Bot changed the title Rename build files from TARGETS to BUCK (group ID: -5056067471429134516) Rename build files from TARGETS to BUCK (group ID: -5056067471429134516) (#19430) May 9, 2026
@bigfootjon bigfootjon force-pushed the export-D104414843 branch from acba734 to a5c83e5 Compare May 9, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants