Rename build files from TARGETS to BUCK (group ID: -5056067471429134516) (#19430)#19430
Rename build files from TARGETS to BUCK (group ID: -5056067471429134516) (#19430)#19430bigfootjon wants to merge 1 commit intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19430
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit a5c83e5 with merge base 93b764e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104414843. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR continues the Buck build-file migration by renaming several TARGETS files to BUCK in the AOTI SlimTensor areas, and updating the AOTI test BUCK file to use the migration wrapper macro.
Changes:
- Replace direct
cpp_unittest(...)invocations withfbcode_target(_kind = cpp_unittest, ...)inbackends/aoti/tests/BUCK. - Remove
TARGETSstubs that only invokeddefine_common_targets(), replacing them with equivalentBUCKfiles invokingfbcode_target(_kind = define_common_targets,). - Standardize these BUCK files to load
build_file_migration.bzlalongside the localtargets.bzl.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| backends/aoti/tests/BUCK | Wrap AOTI unit test targets with fbcode_target for the migration pattern. |
| backends/aoti/slim/util/test/TARGETS | Remove legacy TARGETS stub (migration to BUCK). |
| backends/aoti/slim/util/test/BUCK | Add BUCK calling define_common_targets via fbcode_target. |
| backends/aoti/slim/util/TARGETS | Remove legacy TARGETS stub (migration to BUCK). |
| backends/aoti/slim/util/BUCK | Add BUCK calling define_common_targets via fbcode_target. |
| backends/aoti/slim/factory/test/TARGETS | Remove legacy TARGETS stub (migration to BUCK). |
| backends/aoti/slim/factory/test/BUCK | Add BUCK calling define_common_targets via fbcode_target. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
acba734 to
a5c83e5
Compare
Summary: Pull Request resolved: #19430
Reviewed By: bigfootjon
Differential Revision: D104414843