Skip to content

Rename build files from TARGETS to BUCK (group ID: 3396742412345863445)#19431

Open
bigfootjon wants to merge 1 commit intomainfrom
export-D104414940
Open

Rename build files from TARGETS to BUCK (group ID: 3396742412345863445)#19431
bigfootjon wants to merge 1 commit intomainfrom
export-D104414940

Conversation

@bigfootjon
Copy link
Copy Markdown
Member

Reviewed By: bigfootjon

Differential Revision: D104414940

Reviewed By: bigfootjon

Differential Revision: D104414940
Copilot AI review requested due to automatic review settings May 8, 2026 23:23
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 8, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19431

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit f715acd with merge base 9889c7c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 8, 2026

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104414940.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Buck build definition for extension/kernel_util/test as part of a broader migration/rename from TARGETS to BUCK.

Changes:

  • Added build_file_migration.bzl macro imports to the build file.
  • Replaced a direct define_common_targets() invocation with a fbcode_target(_kind = define_common_targets, ...) wrapper.
Comments suppressed due to low confidence (1)

extension/kernel_util/test/BUCK:10

  • This BUCK file now only invokes define_common_targets via fbcode_target(...), which likely means the common test targets are no longer defined for the non-fbcode/xplat build context. This is also indicated by non_fbcode_target being loaded but never used. If this directory previously had both a BUCK and a TARGETS file that each called define_common_targets(), the merged BUCK should typically call non_fbcode_target(_kind = define_common_targets, ...) for the xplat half and fbcode_target(_kind = define_common_targets, ...) for the fbcode half (see the pattern used in extension/memory_allocator/test/BUCK).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants