Rename build files from TARGETS to BUCK (group ID: 3396742412345863445)#19431
Rename build files from TARGETS to BUCK (group ID: 3396742412345863445)#19431bigfootjon wants to merge 1 commit intomainfrom
Conversation
Reviewed By: bigfootjon Differential Revision: D104414940
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19431
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit f715acd with merge base 9889c7c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104414940. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR updates the Buck build definition for extension/kernel_util/test as part of a broader migration/rename from TARGETS to BUCK.
Changes:
- Added
build_file_migration.bzlmacro imports to the build file. - Replaced a direct
define_common_targets()invocation with afbcode_target(_kind = define_common_targets, ...)wrapper.
Comments suppressed due to low confidence (1)
extension/kernel_util/test/BUCK:10
- This BUCK file now only invokes
define_common_targetsviafbcode_target(...), which likely means the common test targets are no longer defined for the non-fbcode/xplat build context. This is also indicated bynon_fbcode_targetbeing loaded but never used. If this directory previously had both a BUCK and a TARGETS file that each calleddefine_common_targets(), the merged BUCK should typically callnon_fbcode_target(_kind = define_common_targets, ...)for the xplat half andfbcode_target(_kind = define_common_targets, ...)for the fbcode half (see the pattern used inextension/memory_allocator/test/BUCK).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reviewed By: bigfootjon
Differential Revision: D104414940