[MLX] Add aten.bitwise_or op handler#19869
Conversation
Add MLX delegate support for aten.bitwise_or Tensor and Scalar overloads, following the existing bitwise_and path through the FlatBuffer schema, Python op handler, C++ interpreter, and tests. Fixes pytorch#18926.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19869
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Unclassified FailureAs of commit af4d4bf with merge base 40b0a35 ( UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "release notes: apple" |
|
@claude review |
|
Claude finished @nil-is-all's task in 2m 43s —— View job Code Review: [MLX] Add aten.bitwise_or op handler
Verdict: Looks good. This is a clean, well-structured addition that follows the exact same pattern as the existing DetailsSchema (
Runtime (
Python ops (
Tests (
No correctness, performance, or compatibility concerns. The implementation correctly leverages MLX's native |
|
LGTM...let's see what CI says |
|
|
|
@devin-lai it looks like [MLX / backend-tester (models) / test-mlx-backend-models (push)] is failing. Can you have a look at why? |
Summary:
aten.bitwise_orTensor and Scalar overloads.bitwise_orin the runtime interpreter.Fixes #18926.
Testing:
cmake --build cmake-out-mlx --target op_test_runner -j2PATH="$PWD/.venv-mlx/bin:$PATH" .venv-mlx/bin/python -m executorch.backends.mlx.test.run_all_tests bitwise_or_bool bitwise_or_int bitwise_or_scalar --timeout 180cmake --build cmake-out-mlx --target strict_compile_test -j2git diff --checkpy_compileon changed Python fileslintrunner --take FLAKE8,CLANGFORMAT,NEWLINE,ETCAPITAL,LICENSELINTon touched filescc @metascroy