Skip to content

Modernize target_link_libraries in Cmakelists.txt #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moksiuc wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Modernize target_link_libraries in Cmakelists.txt #1283

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52ab4fd
Modernize target_link_libraries in Cmakelists.txt
moksiuc Mar 6, 2026
54d69b2
Merge branch 'refs/heads/main' into moksiuci_8379_modernize_target_li…
moksiuc Mar 18, 2026
e47c13d
Modify only XPU part of cmake file
moksiuc Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libkineto/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ elseif(NOT LIBKINETO_NOCUPTI)
target_link_libraries(kineto_base PUBLIC CUDA::nvperf_host)
endif()
elseif(DEFINED LIBKINETO_NOXPUPTI AND NOT LIBKINETO_NOXPUPTI)
target_link_libraries(kineto "${XPU_xpupti_LIBRARY}")
target_link_libraries(kineto PRIVATE "${XPU_xpupti_LIBRARY}")
elseif(DEFINED LIBKINETO_NOAIUPTI AND NOT LIBKINETO_NOAIUPTI)
target_link_libraries(kineto "${AIU_aiupti_LIBRARY}")
endif()
Expand Down