Add PYTORCH_TEST_WITH_ROCM=1 to test_profiler test for CI (#1289)#1289
Closed
ryanzhang22 wants to merge 1 commit intopytorch:mainfrom
Closed
Add PYTORCH_TEST_WITH_ROCM=1 to test_profiler test for CI (#1289)#1289ryanzhang22 wants to merge 1 commit intopytorch:mainfrom
ryanzhang22 wants to merge 1 commit intopytorch:mainfrom
Conversation
|
Warning: Unknown label
Please add the new label to .github/pytorch-probot.yml |
|
@ryanzhang22 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95839791. |
meta-codesync
bot
changed the title
ryanzhang22
force-pushed
the
export-D95839791
branch
from
61d8ebd to
466e8d2
Compare
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 17, 2026
Summary: For pytorch#1242 I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test. Reviewed By: scotts Differential Revision: D95839791
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 17, 2026
Summary: For pytorch#1242 I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test. Reviewed By: scotts Differential Revision: D95839791
ryanzhang22
force-pushed
the
export-D95839791
branch
from
466e8d2 to
4fbc6d0
Compare
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 17, 2026
Summary: Pull Request resolved: pytorch#1289 For pytorch#1242 I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test. Reviewed By: scotts Differential Revision: D95839791
ryanzhang22
force-pushed
the
export-D95839791
branch
from
4fbc6d0 to
b47c4ab
Compare
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 17, 2026
Summary: For pytorch#1242 I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test. Reviewed By: scotts Differential Revision: D95839791
ryanzhang22
force-pushed
the
export-D95839791
branch
from
b47c4ab to
40297c1
Compare
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 17, 2026
Summary: Pull Request resolved: pytorch#1289 For pytorch#1242 I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test. Reviewed By: scotts Differential Revision: D95839791
ryanzhang22
force-pushed
the
export-D95839791
branch
2 times, most recently
from
dbeccaa to
7e5eea0
Compare
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 18, 2026
Summary: For pytorch#1242 I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test. Reviewed By: scotts Differential Revision: D95839791
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 18, 2026
Summary: For pytorch#1242 I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test. Reviewed By: scotts Differential Revision: D95839791
ryanzhang22
force-pushed
the
export-D95839791
branch
from
7e5eea0 to
e94a8dd
Compare
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 18, 2026
Summary: Pull Request resolved: pytorch#1289 For pytorch#1242 I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test. Reviewed By: scotts Differential Revision: D95839791
ryanzhang22
force-pushed
the
export-D95839791
branch
from
e94a8dd to
201b2b9
Compare
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 18, 2026
Summary: Pull Request resolved: pytorch#1289 For pytorch#1242 I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test. Reviewed By: scotts Differential Revision: D95839791
ryanzhang22
force-pushed
the
export-D95839791
branch
2 times, most recently
from
30afc13 to
32973cf
Compare
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 19, 2026
Summary: For pytorch#1242 I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test. Reviewed By: scotts Differential Revision: D95839791
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 19, 2026
Summary: Pull Request resolved: pytorch#1289 For pytorch#1242 I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test. Reviewed By: scotts Differential Revision: D95839791
ryanzhang22
force-pushed
the
export-D95839791
branch
from
32973cf to
69d815e
Compare
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 19, 2026
Summary: For pytorch#1242 I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test. Reviewed By: scotts Differential Revision: D95839791
ryanzhang22
force-pushed
the
export-D95839791
branch
from
69d815e to
09fbbaf
Compare
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 19, 2026
Summary: Pull Request resolved: pytorch#1289 For pytorch#1242 I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test. Reviewed By: scotts Differential Revision: D95839791
ryanzhang22
force-pushed
the
export-D95839791
branch
from
09fbbaf to
3dfa634
Compare
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 20, 2026
Summary: For pytorch#1242 I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test. Reviewed By: scotts Differential Revision: D95839791
ryanzhang22
force-pushed
the
export-D95839791
branch
from
3dfa634 to
bf17198
Compare
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 20, 2026
Summary: Pull Request resolved: pytorch#1289 For pytorch#1242 I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test. Reviewed By: scotts Differential Revision: D95839791
ryanzhang22
force-pushed
the
export-D95839791
branch
from
bf17198 to
6e18287
Compare
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 20, 2026
Summary: For pytorch#1242 I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test. Reviewed By: scotts Differential Revision: D95839791
ryanzhang22
force-pushed
the
export-D95839791
branch
from
6e18287 to
3ba9123
Compare
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 20, 2026
Summary: Pull Request resolved: pytorch#1289 For pytorch#1242 I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test. Reviewed By: scotts Differential Revision: D95839791
ryanzhang22
force-pushed
the
export-D95839791
branch
from
3ba9123 to
615db0d
Compare
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 23, 2026
Summary: For pytorch#1242 I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test. Reviewed By: scotts Differential Revision: D95839791
ryanzhang22
force-pushed
the
export-D95839791
branch
2 times, most recently
from
2d9230d to
22a1c82
Compare
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 23, 2026
Summary: For pytorch#1242 I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test. Reviewed By: scotts Differential Revision: D95839791
ryanzhang22
force-pushed
the
export-D95839791
branch
from
22a1c82 to
ca4271e
Compare
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Mar 23, 2026
Summary: Pull Request resolved: pytorch#1289 For pytorch#1242 I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test. Reviewed By: scotts Differential Revision: D95839791
Summary: Pull Request resolved: pytorch#1289 For pytorch#1242 I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test. Reviewed By: scotts Differential Revision: D95839791
ryanzhang22
force-pushed
the
export-D95839791
branch
from
ca4271e to
68684be
Compare
|
This pull request has been merged in 8b42d4c. |
smalltalkman
pushed a commit
to smalltalkman/pytorch
that referenced
this pull request
Mar 24, 2026
Contains the following changes: - [pytorch#1289](pytorch/kineto#1289) - Add `PYTORCH_TEST_WITH_ROCM=1` to profiler CI tests - [pytorch#1317](pytorch/kineto#1317) - Move activity_type enum/string map to header file - [pytorch#1315](pytorch/kineto#1315) - Update .gitignore - [pytorch#1320](pytorch/kineto#1320) - Disable `test_schedule_function_count` (segfault fix) - [pytorch#1312](pytorch/kineto#1312) - Add missing `<chrono>` header for Windows builds - [pytorch#1310](pytorch/kineto#1310) - Start flows on `hipGraphLaunch` Pull Request resolved: pytorch#178286 Approved by: https://github.com/scotts, https://github.com/Skylion007
Copilot AI
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Mar 27, 2026
Contains the following changes: - [#1289](pytorch/kineto#1289) - Add `PYTORCH_TEST_WITH_ROCM=1` to profiler CI tests - [#1317](pytorch/kineto#1317) - Move activity_type enum/string map to header file - [#1315](pytorch/kineto#1315) - Update .gitignore - [#1320](pytorch/kineto#1320) - Disable `test_schedule_function_count` (segfault fix) - [#1312](pytorch/kineto#1312) - Add missing `<chrono>` header for Windows builds - [#1310](pytorch/kineto#1310) - Start flows on `hipGraphLaunch` Pull Request resolved: #178286 Approved by: https://github.com/scotts, https://github.com/Skylion007 Co-authored-by: Xia-Weiwen <12522207+Xia-Weiwen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
For #1242
I believe this is causing us to not properly set TEST_WITH_ROCM in the ROCm CI tests, so let's set the flag then un-deselect the test.
Reviewed By: scotts
Differential Revision: D95839791