Disable strict compiles for systems not in our CI#1291
Closed
scotts wants to merge 4 commits intopytorch:mainfrom
Closed
Disable strict compiles for systems not in our CI#1291scotts wants to merge 4 commits intopytorch:mainfrom
scotts wants to merge 4 commits intopytorch:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has some unrelated changes, but I'm doing them all in one so we can unblock upstreaming to PyTorch.
We're still running into trouble bumping PyTorch's submodule hash (pytorch/pytorch#176963). We turned on strict compiles for everything, but we only have tests in our CI for Linux systems for CPU only, CUDA and ROCm. We don't have tests for Mac, Windows and XPU. This PR only enables strict compiles for what we test in our CI. We should add these to our CI to avoid these problems when we upstream.
This also fixes some easy strictness stuff in those files that I'm confident won't cause any problems (casts; maybe unused).
Finally, I'm disabling the linting workflow because it's not lining up with internal. We can deal with that later.