Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show use torch.compile on TorchAO charts #6368

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Mar 6, 2025

Some data is missing on the chart otherwise. For example https://hud.pytorch.org/benchmark/llms?startTime=Thu%2C%2027%20Feb%202025%2001%3A12%3A08%20GMT&stopTime=Thu%2C%2006%20Mar%202025%2001%3A12%3A08%20GMT&granularity=day&lBranch=main&lCommit=6946094f6fe9ff77ca02736567ddf2fc031d5fd300ce7c60d832cf9c301c4c48&rBranch=main&rCommit=6946094f6fe9ff77ca02736567ddf2fc031d5fd300ce7c60d832cf9c301c4c48&repoName=pytorch%2Fao&benchmarkName=&modelName=AlbertForMaskedLM&backendName=&modeName=inference&dtypeName=autoquant&deviceName=cuda%20(NVIDIA%20H100)&archName=All%20Platforms shows only 0.99 on compile v.s eager speedup chart, while it should include the other value (6.85)

Preview

https://torchci-git-fork-huydhn-fix-ao-data-fbopensource.vercel.app/benchmark/llms?startTime=Thu%2C%2027%20Feb%202025%2001%3A12%3A08%20GMT&stopTime=Thu%2C%2006%20Mar%202025%2001%3A12%3A08%20GMT&granularity=day&lBranch=main&lCommit=6946094f6fe9ff77ca02736567ddf2fc031d5fd300ce7c60d832cf9c301c4c48&rBranch=main&rCommit=6946094f6fe9ff77ca02736567ddf2fc031d5fd300ce7c60d832cf9c301c4c48&repoName=pytorch%2Fao&benchmarkName=&modelName=AlbertForMaskedLM&backendName=&modeName=inference&dtypeName=autoquant&deviceName=cuda%20(NVIDIA%20H100)&archName=All%20Platforms shows up the missing value

@jerryzh168 I notice that there could be multiple records of the same model in the same commit, mostly from noquant eager. For example, 6946094f6fe9ff77ca02736567ddf2fc031d5fd300ce7c60d832cf9c301c4c48 and AlbertForMaskedLM has 1 time_ms(avg) record for autoquant, 1 time_ms(avg) record for noquant using torch.compile, but 5 of them for noquant eager. Any thoughts?

Copy link

vercel bot commented Mar 6, 2025

@huydhn is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 6, 2025
Copy link

vercel bot commented Mar 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview Mar 6, 2025 1:55am

@huydhn huydhn requested a review from jerryzh168 March 6, 2025 01:58
@huydhn huydhn marked this pull request as ready for review March 6, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants