Simplify batched_embedding_kernel (#2774) #2779
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Summary: FBGEMM was recently updated to support int32 for embedding tables for EmbeddingBag kernels. We no longer want TorchRec to impose an opinion on the user's input tensors' index/offset type. This was historically included in TorchRec to avoid type errors which are no longer an issue after Benson's changes. FBGEMM also includes guardrails here so TorchRec by default casting the type is redundant. Reviewed By: dstaay-fb, TroyGarden Differential Revision: D69560428
facebook-github-bot
force-pushed
the
export-D69560428
branch
from
d2c97af to
8df236c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
FBGEMM was recently updated to support int32 for embedding tables for EmbeddingBag kernels. We no longer want TorchRec to impose an opinion on the user's input tensors' index/offset type. This was historically included in TorchRec to avoid type errors which are no longer an issue after Benson's changes. FBGEMM also includes guardrails here so TorchRec by default casting the type is redundant.
Reviewed By: dstaay-fb, TroyGarden
Differential Revision: D69560428