reland D70126859 #2787
Open
reland D70126859 #2787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70712348 |
TroyGarden
force-pushed
the
export-D70712348
branch
from
25624eb to
11915e0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70712348 |
TroyGarden
force-pushed
the
export-D70712348
branch
from
11915e0 to
5014024
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70712348 |
Summary:
# context
* previous diff triggered S495021
* the error message is like
```
ModelGenerationPlatformError("AttributeError: '_EmbeddingBagProxy' object has no attribute 'weight'")
```
* this diff works around the `embedding_bag.weight` to access the weight.dtype, instead, using the dtype from the table config.
Differential Revision: D70712348
TroyGarden
force-pushed
the
export-D70712348
branch
from
5014024 to
fd5a483
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70712348 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D70712348