change | to Union for py 3.9 compat #2795
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
iamzainhuda
force-pushed
the
export-D70970656
branch
from
5287ceb to
f03da9b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70970656 |
|
This pull request was exported from Phabricator. Differential Revision: D70970656 |
iamzainhuda
force-pushed
the
export-D70970656
branch
from
f03da9b to
a99e255
Compare
Summary: Pull Request resolved: pytorch#2795 `|` instead of Union causing py3.9 OSS CI to break since `|` was added in python 3.10+ {F1975958588} Reviewed By: kausv Differential Revision: D70970656
|
This pull request was exported from Phabricator. Differential Revision: D70970656 |
iamzainhuda
force-pushed
the
export-D70970656
branch
from
a99e255 to
ed303e8
Compare
jingsh
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
|instead of Union causing py3.9 OSS CI to break since|was added in python 3.10+Differential Revision: D70970656