Skip to content

Enable async checkpointing for distributed recipes #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ankitageorge
Copy link
Contributor

Context

What is the purpose of this PR? Is it to

  • [x ] add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

Please link to any issues this PR addresses.

Changelog

What are the changes made in this PR?

  • Separate PRs have enabled distributed async checkpointing with DCP for intermediate checkpoints for full_finetune_distributed and dpo_distributed recipes. This does the same for the remaining distributed recipes.

Test plan

Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

  • [ x] run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • [ x] add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • [x ] run unit tests via pytest tests
  • [x ] run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example

  • I did not change any public API
  • I have added an example to docs or docstrings

Copy link

pytorch-bot bot commented May 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2660

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Cancelled Jobs

As of commit 5765fb3 with merge base 0991f97 (image):

NEW FAILURES - The following jobs have failed:

  • GPU tests / gpu_test (3.11, stable) (gh)
    tests/recipes/test_qat_lora_finetune_distributed.py::TestQATLoRAFinetuneDistributedRecipe::test_save_and_load_merged_weights[llama3/8B_qat_lora-llama3-tune]
  • Lint / lint (3.10) (gh)
    tests/recipes/test_knowledge_distillation_distributed.py:298:5: F811 redefinition of unused 'test_training_state_on_resume_with_async_checkpointing' from line 206

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 2, 2025
@ankitageorge ankitageorge force-pushed the distributed_recipes_dcp branch from 6e3afd3 to 2f11964 Compare May 2, 2025 15:59
@ankitageorge ankitageorge force-pushed the distributed_recipes_dcp branch from a56aa4b to ca7f426 Compare May 8, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants