Skip to content

[not to land] Tiny Llama4 debug model, activation offloading repro #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ebsmothers
Copy link
Contributor

No description provided.

Copy link

pytorch-bot bot commented May 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2708

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 194cdf3 with merge base 3310946 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2025
@ebsmothers ebsmothers changed the title Tiny Llama4 model for debugging, activation offloading repro [not to land] Tiny Llama4 debug model, activation offloading repro May 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2025

Codecov Report

Attention: Patch coverage is 11.53846% with 23 lines in your changes missing coverage. Please review.

Project coverage is 60.60%. Comparing base (113807c) to head (194cdf3).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
torchtune/models/llama4/_model_builders.py 13.33% 13 Missing ⚠️
torchtune/training/_activation_offloading.py 0.00% 5 Missing ⚠️
torchtune/training/_grad_scaler.py 20.00% 4 Missing ⚠️
recipes/full_finetune_distributed.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2708      +/-   ##
==========================================
- Coverage   63.37%   60.60%   -2.78%     
==========================================
  Files         425      425              
  Lines       25647    25785     +138     
==========================================
- Hits        16255    15627     -628     
- Misses       9392    10158     +766     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants