Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment verification #2389

Merged
merged 33 commits into from
Mar 17, 2025
Merged

Assignment verification #2389

merged 33 commits into from
Mar 17, 2025

Conversation

kamilsa
Copy link
Contributor

@kamilsa kamilsa commented Mar 4, 2025

Referenced issues

https://github.com/qdrvm/KAGOME-audit/issues/48

Should be merged after qdrvm/kagome-crates#8 containing necessary new bindings to sr25519 functions

Description of the Change

Adds additional checks into assignments certificate validation

Possible Drawbacks

None

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? [Yes|No]
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? [Yes|No]
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? [Yes|No]
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. [Yes|No]

@kamilsa kamilsa marked this pull request as ready for review March 4, 2025 13:56
@kamilsa kamilsa requested review from iceseer and xDimon March 4, 2025 14:03
@kamilsa kamilsa merged commit 4a24e68 into master Mar 17, 2025
13 checks passed
@kamilsa kamilsa deleted the feature/assignment-verification branch March 17, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants